Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many of the features not yet implemented tfp.math.ode.BDF. #600

Open
wolfiex opened this issue Oct 10, 2019 · 3 comments
Open

Many of the features not yet implemented tfp.math.ode.BDF. #600

wolfiex opened this issue Oct 10, 2019 · 3 comments

Comments

@wolfiex
Copy link

wolfiex commented Oct 10, 2019

It seems that many of the features/possible arguments are not yet implemented into the algorithm, is there a bleeding-edge version that has these? When will they be expected?

@brianwa84
Copy link
Contributor

Unfortunately the driver on the BDF front has stepped away, there aren't current efforts to improve the BDF solver. Are there particular stiff ODE problems that you're interested in?

You might be interested to find we just added a RK type solver (non-stiff), DormandPrince.
https://github.com/tensorflow/probability/blob/master/tensorflow_probability/python/math/ode/dormand_prince.py

Quoting Dimitriii, who just added DOPRI:
From my limited experience I think that for many semi-large scale ML applications explicit solver such as DormandPrince fits better. (mostly due to memory efficiency and speed) I've been adding some nice features to it, such as support for nested structures. There's still some work to tune it up (proper batching, some extra profiling), but it's close to a good working solver. It's also easier to add features to DormanPrince, as it is conceptually simpler.

@wolfiex
Copy link
Author

wolfiex commented Oct 11, 2019

Oh thats a shame - It is probably worth hilighting the features which are not enabled on the documentation.

I have a large, sparse numerically stiff chemical system I wish to solve, and thus need ideally a BDF or Rosebrock integrator. The task in itself is not necessarily ML based, although the direct integration into other projects, and tf's sparse tensor representation would be very useful.

@SiegeLordEx
Copy link
Member

That sounds like a very interesting application! We're certainly open to re-prioritizing things and implementing what's necessary if possible. Could you clarify which features you'd like to see most and how you were planning on using the sparse tensor representation? Were you planning to compute gradients of your ODE simulation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants