Skip to content

Revert "tf_upgrade_v2 on resnet and utils folders. (#6154)" #6162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Revert "tf_upgrade_v2 on resnet and utils folders. (#6154)" #6162

merged 1 commit into from
Feb 6, 2019

Conversation

goldiegadde
Copy link
Contributor

This reverts commit d6b2b83.

@goldiegadde goldiegadde requested review from karmel and a team as code owners February 6, 2019 19:21
Copy link
Contributor

@karmel karmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Goldie-- can we then create a branch that is synced to the prior commit (right before this rollback) for v2 for now?

@goldiegadde
Copy link
Contributor Author

Thanks, Goldie-- can we then create a branch that is synced to the prior commit (right before this rollback) for v2 for now?

@tfboyd , so that he is informed.

@goldiegadde
Copy link
Contributor Author

Thanks, Goldie-- can we then create a branch that is synced to the prior commit (right before this rollback) for v2 for now?

@tfboyd , so that he is informed. Yes I think we can do that.

@tfboyd tfboyd merged commit 57e0752 into tensorflow:master Feb 6, 2019
@tfboyd
Copy link
Member

tfboyd commented Feb 6, 2019

Why it was decided to stop tagging this feels crazy.

@tfboyd
Copy link
Member

tfboyd commented Feb 6, 2019

@karmel I want to test the following

  • I want to main branch to be compat.v1 or pure TF 1.0. So we can test TF 1.0 with compat along with some TF 2.0 testing.
  • a separate branch where we are doing V2 that will cannot exist at the same time easily.

@tfboyd
Copy link
Member

tfboyd commented Feb 6, 2019

Keep in mind the README says this.

The master branch of the models are in development, and they target the nightly binaries built from the master branch of TensorFlow. We aim to keep them backwards compatible with the latest release when possible (currently TensorFlow 1.5), but we cannot always guarantee compatibility.

@karmel
Copy link
Contributor

karmel commented Feb 6, 2019

@tfboyd -- I think we resolved offline, but sounds like this is a problem with an older version, and the current Models HEAD works with TF 1.x HEAD, in which case a rollback/branch is not necessary. Sorry for the thrash on this, @goldiegadde

@f23505106
Copy link

class ExamplesPerSecondHook(tf.estimator.SessionRunHook):

AttributeError: module 'tensorflow.python.estimator.api.estimator' has no attribute 'SessionRunHook'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants