Skip to content

Conversation

@MustafaLotfi
Copy link
Contributor

In the documentation that is provided for MoViNet tutorial, it says we will download MoViNet-A0-Stream. But In the code MoViNet-A2 is downloaded and used.

@google-cla
Copy link

google-cla bot commented Apr 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@laxmareddyp laxmareddyp requested review from Chen-Zhe and chaoyan1037 and removed request for rachellj218 and saberkun April 4, 2024 18:55
@laxmareddyp
Copy link
Collaborator

Hi @Chen-Zhe @chaoyan1037 ,

PR having typo changes , Please approve in your free time.Thanks

@laxmareddyp laxmareddyp added the models:official models that come under official repository label Apr 4, 2024
@LakshmiKalaKadali
Copy link
Collaborator

Hi @Chen-Zhe, @chaoyan1037,

Could you please review the PR.

Thank You

Copy link
Collaborator

@chaoyan1037 chaoyan1037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of change comments, maybe update "load_movinet_from_hub('a2', 'stream', hub_version=3)" to be "load_movinet_from_hub('a0', 'stream', hub_version=3)" since the following section Export a Streaming Model to TensorFlow Lite for Mobile also use 'a0' as example.

@MustafaLotfi
Copy link
Contributor Author

@chaoyan1037
In the previous cells, MoViNet-A2-base is loaded and used, Wouldn't it be a better approach to use a same version (A2) for stream model too?

@chaoyan1037
Copy link
Collaborator

I see.

@chaoyan1037 chaoyan1037 self-requested a review October 19, 2024 18:42
@laxmareddyp laxmareddyp added the ready to pull ready to pull (create internal pr review and merge automatically) label Oct 19, 2024
@copybara-service copybara-service bot merged commit 7ffafd0 into tensorflow:master Oct 23, 2024
2 checks passed
copybara-service bot pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models:official models that come under official repository ready to pull ready to pull (create internal pr review and merge automatically)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants