Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cost calculation question in DETR model #11048

Open
GongXinyuu opened this issue Jul 14, 2023 · 0 comments
Open

Cost calculation question in DETR model #11048

GongXinyuu opened this issue Jul 14, 2023 · 0 comments
Assignees
@luotigerlsx @fyangf @laxmareddyp
Labels
models:official models that come under official repository stat:awaiting model gardener Waiting on input from TensorFlow model gardener

Comments

@GongXinyuu
Copy link

Hi, thanks for your great work.

I have a question regarding themax_cost calculation in the DETR model. As the giou loss's value range is [1, -1], shouldn't this line be:

        self._task_config.losses.lambda_giou * 1.0)

instead of

models/official/projects/detr/tasks/detection.py

Line 148 in 747c4df

self._task_config.losses.lambda_giou * 0.0)

@laxmareddyp laxmareddyp assigned laxmareddyp and unassigned sineeli Jul 14, 2023
@sineeli sineeli added the models:official models that come under official repository label Jul 14, 2023
@laxmareddyp laxmareddyp added the stat:awaiting model gardener Waiting on input from TensorFlow model gardener label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luotigerlsx luotigerlsx

@fyangf fyangf

@laxmareddyp laxmareddyp

Labels
models:official models that come under official repository stat:awaiting model gardener Waiting on input from TensorFlow model gardener
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@luotigerlsx @GongXinyuu @fyangf @laxmareddyp @sineeli