Pom profile changes #525
Pom profile changes #525
Conversation
|
As I pointed out before, this isn't going to work with other tools than Maven... |
|
It worked when we tested it with gradle earlier today as it defaults in the pom and platform pulls in all the dependencies. |
tensorflow-core/pom.xml
Outdated
| <property> | ||
| <name>javacpp.platform.host</name> | ||
| <name>!javacpp.platform</name> |
There was a problem hiding this comment.
There is no need of having this profile if we set the default value of javacpp.platform to ${os.name}-${os.arch} by default in the pom properties, and simply let user override it in the command line if needed
The new strategy here @saudet is that we'll build |
|
Yeah, sure, feel free to experiment, but do test with other tools is all I can recommend. In the end, I think you'll find the the way I'm doing it in the presets is the least worst |
tensorflow-core/pom.xml
Outdated
| @@ -74,6 +72,9 @@ | |||
| <properties> | |||
| <javacpp.platform>${os.name}-${os.arch}</javacpp.platform> | |||
| </properties> | |||
There was a problem hiding this comment.
This should be removed as well, as it will be set in the top properties on this file
| @@ -41,25 +41,25 @@ | |||
| <groupId>org.tensorflow</groupId> | |||
| <artifactId>tensorflow-core-native</artifactId> | |||
| <version>${project.version}</version> | |||
| <classifier>${javacpp.platform.linux-x86_64.extension}</classifier> | |||
| <classifier>linux-x86_64</classifier> | |||
There was a problem hiding this comment.
Maybe we should keep using properties but the with an extension here (e.g. ${javacpp.platform.linux-x86_64), just so we know the values are consistent. Not strong opinion either way.
Switch
tensorflow-core-platformso it's only generated when thedeployingprofile is set. Lets the profiles default through so the platform has the correct values when pulled in without any profiles activated.