Skip to content

Commit de1d6f0

Browse files
Craigacpkarllessard
authored andcommitted
Spotless fixes.
1 parent 911fb28 commit de1d6f0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+299
-228
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
<maven.javadoc.skip>true</maven.javadoc.skip>
4848
<maven.source.skip>true</maven.source.skip>
4949
<gpg.skip>true</gpg.skip>
50-
<spotless.version>2.38.0</spotless.version>
50+
<spotless.version>2.43.0</spotless.version>
5151
</properties>
5252

5353
<repositories>
@@ -564,7 +564,7 @@
564564
<lineEndings/>
565565
<java>
566566
<googleJavaFormat>
567-
<version>1.17.0</version>
567+
<version>1.20.0</version>
568568
</googleJavaFormat>
569569
<removeUnusedImports/>
570570
</java>

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/AbstractGradientAdapter.java

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,14 @@
1818

1919
import java.util.ArrayList;
2020
import java.util.List;
21-
2221
import org.bytedeco.javacpp.Pointer;
2322
import org.bytedeco.javacpp.PointerPointer;
2423
import org.bytedeco.javacpp.PointerScope;
25-
import org.tensorflow.internal.c_api.TF_Operation;
26-
import org.tensorflow.internal.c_api.TF_Output;
27-
import org.tensorflow.internal.c_api.TFJ_Scope;
2824
import org.tensorflow.internal.c_api.TFJ_GradFuncAdapter;
2925
import org.tensorflow.internal.c_api.TFJ_GraphId;
26+
import org.tensorflow.internal.c_api.TFJ_Scope;
27+
import org.tensorflow.internal.c_api.TF_Operation;
28+
import org.tensorflow.internal.c_api.TF_Output;
3029

3130
/** Helper base class for custom gradient adapters <b>INTERNAL USE ONLY</b> */
3231
public abstract class AbstractGradientAdapter extends TFJ_GradFuncAdapter {
@@ -35,10 +34,17 @@ protected AbstractGradientAdapter() {
3534
super();
3635
}
3736

38-
protected abstract List<Operand<?>> apply(Graph graph, TFJ_Scope scope, GraphOperation operation, List<Output<?>> gradInputs);
37+
protected abstract List<Operand<?>> apply(
38+
Graph graph, TFJ_Scope scope, GraphOperation operation, List<Output<?>> gradInputs);
3939

4040
@Override
41-
public int call(TFJ_GraphId nativeGraphId, TFJ_Scope nativeScope, TF_Operation nativeOperation, TF_Output nativeGradInputs, int nativeGradInputsLength, PointerPointer nativeGradOutputsPtr) {
41+
public int call(
42+
TFJ_GraphId nativeGraphId,
43+
TFJ_Scope nativeScope,
44+
TF_Operation nativeOperation,
45+
TF_Output nativeGradInputs,
46+
int nativeGradInputsLength,
47+
PointerPointer nativeGradOutputsPtr) {
4248
try (PointerScope callScope = new PointerScope()) {
4349
var graph = Graph.findGraph(nativeGraphId);
4450
var operation = new GraphOperation(graph, nativeOperation);
@@ -67,7 +73,8 @@ private static List<Output<?>> fromNativeOutputs(Graph g, TF_Output nativeOutput
6773
List<Output<?>> outputs = new ArrayList<>(length);
6874
for (int i = 0; i < length; ++i) {
6975
var nativeOutput = nativeOutputs.position(i);
70-
outputs.add(i, new Output<>(new GraphOperation(g, nativeOutput.oper()), nativeOutput.index()));
76+
outputs.add(
77+
i, new Output<>(new GraphOperation(g, nativeOutput.oper()), nativeOutput.index()));
7178
}
7279
return outputs;
7380
}
@@ -79,13 +86,15 @@ private static List<Output<?>> fromNativeOutputs(Graph g, TF_Output nativeOutput
7986
* @return pointer to the native array of outputs
8087
*/
8188
private static TF_Output toNativeOutputs(List<Operand<?>> outputs) {
82-
// Use malloc to allocate native outputs, as they will be freed by the native layer and we do not want JavaCPP to deallocate them
83-
var nativeOutputs = new TF_Output(Pointer.malloc((long)outputs.size() * Pointer.sizeof(TF_Output.class)));
89+
// Use malloc to allocate native outputs, as they will be freed by the native layer and we do
90+
// not want JavaCPP to deallocate them
91+
var nativeOutputs =
92+
new TF_Output(Pointer.malloc((long) outputs.size() * Pointer.sizeof(TF_Output.class)));
8493

8594
for (int i = 0; i < outputs.size(); ++i) {
8695
var output = outputs.get(i).asOutput();
8796
var nativeOutput = nativeOutputs.getPointer(i);
88-
nativeOutput.oper(((GraphOperation)output.op()).getUnsafeNativeHandle());
97+
nativeOutput.oper(((GraphOperation) output.op()).getUnsafeNativeHandle());
8998
nativeOutput.index(output.index());
9099
}
91100
return nativeOutputs;

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/Graph.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.tensorflow;
1717

18+
import static org.tensorflow.internal.c_api.global.tensorflow.TFJ_GetGraphId;
1819
import static org.tensorflow.internal.c_api.global.tensorflow.TF_AddGradientsWithPrefix;
1920
import static org.tensorflow.internal.c_api.global.tensorflow.TF_DeleteGraph;
2021
import static org.tensorflow.internal.c_api.global.tensorflow.TF_FinishWhile;
@@ -28,7 +29,6 @@
2829
import static org.tensorflow.internal.c_api.global.tensorflow.TF_ImportGraphDefOptionsSetPrefix;
2930
import static org.tensorflow.internal.c_api.global.tensorflow.TF_NewGraph;
3031
import static org.tensorflow.internal.c_api.global.tensorflow.TF_NewWhile;
31-
import static org.tensorflow.internal.c_api.global.tensorflow.TFJ_GetGraphId;
3232

3333
import com.google.protobuf.InvalidProtocolBufferException;
3434
import java.util.ArrayDeque;
@@ -50,6 +50,7 @@
5050
import org.bytedeco.javacpp.PointerScope;
5151
import org.bytedeco.javacpp.SizeTPointer;
5252
import org.tensorflow.exceptions.TensorFlowException;
53+
import org.tensorflow.internal.c_api.TFJ_GraphId;
5354
import org.tensorflow.internal.c_api.TF_Buffer;
5455
import org.tensorflow.internal.c_api.TF_Function;
5556
import org.tensorflow.internal.c_api.TF_Graph;
@@ -58,7 +59,6 @@
5859
import org.tensorflow.internal.c_api.TF_Output;
5960
import org.tensorflow.internal.c_api.TF_Status;
6061
import org.tensorflow.internal.c_api.TF_WhileParams;
61-
import org.tensorflow.internal.c_api.TFJ_GraphId;
6262
import org.tensorflow.ndarray.StdArrays;
6363
import org.tensorflow.op.Op;
6464
import org.tensorflow.op.OpScope;
@@ -1319,7 +1319,8 @@ private static SaverDef addVariableSaver(Graph graph) {
13191319
.build();
13201320
}
13211321

1322-
private static final Map<TFJ_GraphId, Graph> ALL_GRAPHS = Collections.synchronizedMap(new WeakHashMap<>());
1322+
private static final Map<TFJ_GraphId, Graph> ALL_GRAPHS =
1323+
Collections.synchronizedMap(new WeakHashMap<>());
13231324

13241325
/**
13251326
* Find the graph with the matching ID.

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/GraphOperationBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.tensorflow;
1717

18+
import static org.tensorflow.internal.c_api.global.tensorflow.TFJ_UnmapOperationName;
1819
import static org.tensorflow.internal.c_api.global.tensorflow.TF_AddControlInput;
1920
import static org.tensorflow.internal.c_api.global.tensorflow.TF_AddInput;
2021
import static org.tensorflow.internal.c_api.global.tensorflow.TF_AddInputList;
@@ -39,7 +40,6 @@
3940
import static org.tensorflow.internal.c_api.global.tensorflow.TF_SetAttrTypeList;
4041
import static org.tensorflow.internal.c_api.global.tensorflow.TF_SetAttrValueProto;
4142
import static org.tensorflow.internal.c_api.global.tensorflow.TF_SetDevice;
42-
import static org.tensorflow.internal.c_api.global.tensorflow.TFJ_UnmapOperationName;
4343

4444
import java.nio.charset.Charset;
4545
import java.util.Arrays;

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/Signature.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ public static class TensorDescription {
3939

4040
/** The name of the tensor's operand in the graph */
4141
public final String name;
42+
4243
/** The data type of the tensor */
4344
public final DataType dataType;
4445

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/TensorFlow.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,37 +15,36 @@
1515
*/
1616
package org.tensorflow;
1717

18+
import static org.tensorflow.internal.c_api.global.tensorflow.TFJ_HasGradient;
19+
import static org.tensorflow.internal.c_api.global.tensorflow.TFJ_RegisterCustomGradient;
1820
import static org.tensorflow.internal.c_api.global.tensorflow.TF_DeleteBuffer;
1921
import static org.tensorflow.internal.c_api.global.tensorflow.TF_DeleteLibraryHandle;
2022
import static org.tensorflow.internal.c_api.global.tensorflow.TF_GetAllOpList;
2123
import static org.tensorflow.internal.c_api.global.tensorflow.TF_GetOpList;
2224
import static org.tensorflow.internal.c_api.global.tensorflow.TF_LoadLibrary;
2325
import static org.tensorflow.internal.c_api.global.tensorflow.TF_RegisterFilesystemPlugin;
2426
import static org.tensorflow.internal.c_api.global.tensorflow.TF_Version;
25-
import static org.tensorflow.internal.c_api.global.tensorflow.TFJ_HasGradient;
26-
import static org.tensorflow.internal.c_api.global.tensorflow.TFJ_RegisterCustomGradient;
2727

2828
import com.google.protobuf.InvalidProtocolBufferException;
29+
import java.util.Collections;
30+
import java.util.IdentityHashMap;
31+
import java.util.Locale;
32+
import java.util.Set;
33+
import java.util.stream.Collectors;
2934
import org.bytedeco.javacpp.PointerScope;
3035
import org.tensorflow.exceptions.TensorFlowException;
36+
import org.tensorflow.internal.c_api.TFJ_GradFuncAdapter;
37+
import org.tensorflow.internal.c_api.TFJ_RuntimeLibrary;
3138
import org.tensorflow.internal.c_api.TF_Buffer;
3239
import org.tensorflow.internal.c_api.TF_Library;
3340
import org.tensorflow.internal.c_api.TF_Status;
34-
import org.tensorflow.internal.c_api.TFJ_GradFuncAdapter;
35-
import org.tensorflow.internal.c_api.TFJ_RuntimeLibrary;
3641
import org.tensorflow.op.CustomGradient;
3742
import org.tensorflow.op.RawCustomGradient;
3843
import org.tensorflow.op.RawOpInputs;
3944
import org.tensorflow.op.annotation.OpInputsMetadata;
4045
import org.tensorflow.op.annotation.OpMetadata;
4146
import org.tensorflow.proto.OpList;
4247

43-
import java.util.Collections;
44-
import java.util.IdentityHashMap;
45-
import java.util.Locale;
46-
import java.util.Set;
47-
import java.util.stream.Collectors;
48-
4948
/** Static utility methods describing the TensorFlow runtime. */
5049
public final class TensorFlow {
5150

@@ -199,7 +198,8 @@ static synchronized boolean hasGradient(String opType) {
199198
* @return {@code true} if the gradient was registered, {@code false} if there was already a
200199
* gradient registered for this op
201200
*/
202-
public static synchronized boolean registerCustomGradient(String opType, RawCustomGradient gradient) {
201+
public static synchronized boolean registerCustomGradient(
202+
String opType, RawCustomGradient gradient) {
203203
if (isWindowsOs()) {
204204
throw new UnsupportedOperationException(
205205
"Custom gradient registration is not supported on Windows systems.");

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TBfloat16Mapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
import org.tensorflow.types.TInt64;
3131

3232
/**
33-
* Maps memory of {@link org.tensorflow.proto.DataType#DT_BFLOAT16} tensors to a
34-
* n-dimensional data space.
33+
* Maps memory of {@link org.tensorflow.proto.DataType#DT_BFLOAT16} tensors to a n-dimensional data
34+
* space.
3535
*/
3636
public final class TBfloat16Mapper extends TensorMapper<TBfloat16> {
3737

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TBoolMapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
import org.tensorflow.types.TInt64;
3030

3131
/**
32-
* Maps memory of {@link org.tensorflow.proto.DataType#DT_BOOL} tensors to a n-dimensional
33-
* data space.
32+
* Maps memory of {@link org.tensorflow.proto.DataType#DT_BOOL} tensors to a n-dimensional data
33+
* space.
3434
*/
3535
public final class TBoolMapper extends TensorMapper<TBool> {
3636

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TFloat16Mapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
import org.tensorflow.types.TInt64;
3131

3232
/**
33-
* Maps memory of {@link org.tensorflow.proto.DataType#DT_HALF} tensors to a n-dimensional
34-
* data space.
33+
* Maps memory of {@link org.tensorflow.proto.DataType#DT_HALF} tensors to a n-dimensional data
34+
* space.
3535
*/
3636
public final class TFloat16Mapper extends TensorMapper<TFloat16> {
3737

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TFloat32Mapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
import org.tensorflow.types.TInt64;
3030

3131
/**
32-
* Maps memory of {@link org.tensorflow.proto.DataType#DT_FLOAT} tensors to a
33-
* n-dimensional data space.
32+
* Maps memory of {@link org.tensorflow.proto.DataType#DT_FLOAT} tensors to a n-dimensional data
33+
* space.
3434
*/
3535
public final class TFloat32Mapper extends TensorMapper<TFloat32> {
3636

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TFloat64Mapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
import org.tensorflow.types.TInt64;
3030

3131
/**
32-
* Maps memory of {@link org.tensorflow.proto.DataType#DT_DOUBLE} tensors to a
33-
* n-dimensional data space.
32+
* Maps memory of {@link org.tensorflow.proto.DataType#DT_DOUBLE} tensors to a n-dimensional data
33+
* space.
3434
*/
3535
public final class TFloat64Mapper extends TensorMapper<TFloat64> {
3636

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TInt32Mapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
import org.tensorflow.types.TInt64;
3030

3131
/**
32-
* Maps memory of {@link org.tensorflow.proto.DataType#DT_INT32} tensors to a
33-
* n-dimensional data space.
32+
* Maps memory of {@link org.tensorflow.proto.DataType#DT_INT32} tensors to a n-dimensional data
33+
* space.
3434
*/
3535
public final class TInt32Mapper extends TensorMapper<TInt32> {
3636

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TInt64Mapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
import org.tensorflow.types.TInt64;
2929

3030
/**
31-
* Maps memory of {@link org.tensorflow.proto.DataType#DT_INT64} tensors to a
32-
* n-dimensional data space.
31+
* Maps memory of {@link org.tensorflow.proto.DataType#DT_INT64} tensors to a n-dimensional data
32+
* space.
3333
*/
3434
public final class TInt64Mapper extends TensorMapper<TInt64> {
3535

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TStringMapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@
3737
import org.tensorflow.types.TString;
3838

3939
/**
40-
* Maps memory of {@link org.tensorflow.proto.DataType#DT_STRING} tensors to a
41-
* n-dimensional data space.
40+
* Maps memory of {@link org.tensorflow.proto.DataType#DT_STRING} tensors to a n-dimensional data
41+
* space.
4242
*/
4343
public final class TStringMapper extends TensorMapper<TString> {
4444

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TUint16Mapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
import org.tensorflow.types.TUint16;
3030

3131
/**
32-
* Maps memory of {@link org.tensorflow.proto.DataType#DT_Uint16} tensors to a
33-
* n-dimensional data space.
32+
* Maps memory of {@link org.tensorflow.proto.DataType#DT_Uint16} tensors to a n-dimensional data
33+
* space.
3434
*/
3535
public final class TUint16Mapper extends TensorMapper<TUint16> {
3636

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/internal/types/TUint8Mapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
import org.tensorflow.types.TUint8;
3030

3131
/**
32-
* Maps memory of {@link org.tensorflow.proto.DataType#DT_UINT8} tensors to a
33-
* n-dimensional data space.
32+
* Maps memory of {@link org.tensorflow.proto.DataType#DT_UINT8} tensors to a n-dimensional data
33+
* space.
3434
*/
3535
public final class TUint8Mapper extends TensorMapper<TUint8> {
3636

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/op/CustomGradient.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,12 @@
1616
*/
1717
package org.tensorflow.op;
1818

19+
import java.util.List;
1920
import org.tensorflow.Operand;
2021
import org.tensorflow.Output;
2122
import org.tensorflow.TensorFlow;
2223
import org.tensorflow.internal.c_api.TFJ_GradFuncAdapter;
2324

24-
import java.util.List;
25-
2625
/**
2726
* A custom gradient for ops of type {@link T}. Should be registered using {@link
2827
* TensorFlow#registerCustomGradient(Class, CustomGradient)}.
@@ -56,7 +55,8 @@ public interface CustomGradient<T extends RawOpInputs> {
5655
* <p>You should not be calling this yourself, use {@link TensorFlow#registerCustomGradient(Class,
5756
* CustomGradient)}.
5857
*/
59-
static <T extends RawOpInputs<?>> TFJ_GradFuncAdapter adapter(CustomGradient<T> gradient, Class<T> opClass) {
58+
static <T extends RawOpInputs<?>> TFJ_GradFuncAdapter adapter(
59+
CustomGradient<T> gradient, Class<T> opClass) {
6060
return new TypedGradientAdapter<T>(gradient, opClass);
6161
}
62-
}
62+
}

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/op/NativeScope.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
import org.tensorflow.GraphOperation;
3131
import org.tensorflow.Operation;
3232
import org.tensorflow.OperationBuilder;
33-
import org.tensorflow.internal.c_api.TF_Operation;
3433
import org.tensorflow.internal.c_api.TFJ_Scope;
34+
import org.tensorflow.internal.c_api.TF_Operation;
3535

3636
/** A {@link Scope} implementation backed by a native scope. */
3737
public final class NativeScope implements Scope {
@@ -87,7 +87,8 @@ public void refreshNames() {}
8787

8888
@Override
8989
public Scope withControlDependencies(Iterable<Op> controls) {
90-
return withControlDependencyOps(StreamSupport.stream(controls.spliterator(), false)
90+
return withControlDependencyOps(
91+
StreamSupport.stream(controls.spliterator(), false)
9192
.map(Op::op)
9293
.collect(Collectors.toList()));
9394
}

tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/op/RawCustomGradient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,4 @@ public interface RawCustomGradient {
5656
static TFJ_GradFuncAdapter adapter(RawCustomGradient gradient) {
5757
return new RawGradientAdapter(gradient);
5858
}
59-
}
59+
}

0 commit comments

Comments
 (0)