S3_ENDPOINT supports http/https

Author: vnghia

tensorflow_io/core/plugins/s3/s3_filesystem.cc

@@ -135,8 +135,6 @@ static Aws::Client::ClientConfiguration& GetDefaultClientConfig() {
   absl::MutexLock l(&cfg_lock);
 
   if (!init) {
-    const char* endpoint = getenv("S3_ENDPOINT");
-    if (endpoint) cfg.endpointOverride = Aws::String(endpoint);
     const char* region = getenv("AWS_REGION");
     // TODO (yongtang): `S3_REGION` should be deprecated after 2.0.
     if (!region) region = getenv("S3_REGION");
@@ -241,9 +239,13 @@ static void GetS3Client(tf_s3_filesystem::S3File* s3_file) {
             tf_s3_filesystem::AWSLogSystem::ShutdownAWSLogging();
           }
         });
+
     int temp_value;
     if (absl::SimpleAtoi(getenv("S3_DISABLE_MULTI_PART_DOWNLOAD"), &temp_value))
       s3_file->use_multi_part_download = (temp_value != 1);
+
+    const char* endpoint = getenv("S3_ENDPOINT");
+    if (endpoint) s3_file->s3_client->OverrideEndpoint(endpoint);
   }
 }
 

tests/test_s3.py

@@ -51,9 +51,7 @@ def test_read_file():
     response = client.get_object(Bucket=bucket_name, Key=key_name)
     assert response["Body"].read() == body
 
-    os.environ["S3_ENDPOINT"] = "localhost:4566"
-    os.environ["S3_USE_HTTPS"] = "0"
-    os.environ["S3_VERIFY_SSL"] = "0"
+    os.environ["S3_ENDPOINT"] = "http://localhost:4566"
 
     content = tf.io.read_file("s3://{}/{}".format(bucket_name, key_name))
     assert content == body