Skip to content

Commit 5c652be

Browse files
authored
Disable s3 macOS for now as docker is not working on GitHub Actions for macOS (#1277)
* Revert "[s3] add support for testing on macOS (#1253)" This reverts commit 81789bd. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Update Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
1 parent 3e16038 commit 5c652be

File tree

5 files changed

+7
-26
lines changed

5 files changed

+7
-26
lines changed

.github/workflows/api.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ jobs:
2222
version: ['tensorflow==2.4.0:tensorflow-io-nightly', 'tf-nightly:tensorflow-io==0.17.0', 'tf-nightly:tensorflow-io-nightly']
2323
steps:
2424
- uses: actions/checkout@v2
25-
- uses: docker-practice/actions-setup-docker@v1
2625
- uses: actions/setup-python@v1
2726
with:
2827
python-version: ${{ matrix.python }}
@@ -33,9 +32,7 @@ jobs:
3332
- name: Setup macOS
3433
run: |
3534
set -x -e
36-
docker version
3735
bash -x -e tests/test_azure/start_azure.sh
38-
bash -x -e tests/test_aws/aws_test.sh
3936
- name: Test macOS
4037
run: |
4138
set -x -e

.github/workflows/build.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@ jobs:
162162
python: ['3.7', '3.8']
163163
steps:
164164
- uses: actions/checkout@v2
165-
- uses: docker-practice/actions-setup-docker@v1
166165
- uses: actions/download-artifact@v1
167166
with:
168167
name: ${{ runner.os }}-${{ matrix.python }}-wheel
@@ -177,11 +176,9 @@ jobs:
177176
- name: Setup ${{ matrix.python }} macOS
178177
run: |
179178
set -x -e
180-
docker version
181179
bash -x -e tests/test_kafka/kafka_test.sh
182180
bash -x -e tests/test_azure/start_azure.sh
183181
bash -x -e tests/test_pubsub/pubsub_test.sh
184-
bash -x -e tests/test_aws/aws_test.sh
185182
bash -x -e tests/test_pulsar/pulsar_test.sh
186183
bash -x -e tests/test_mongodb/mongodb_test.sh start
187184
- name: Install ${{ matrix.python }} macOS

tests/test_aws/aws_test.sh

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@
1717
set -e
1818
set -o pipefail
1919

20-
export LOCALSTACK_VERSION=0.12.2
21-
cd tests/test_aws
22-
TMPDIR=/private$TMPDIR docker-compose up -d
23-
cd -
24-
echo "Waiting for 20 secs until localstack is up and running"
25-
sleep 20
20+
LOCALSTACK_VERSION=0.12.2
21+
docker pull localstack/localstack:$LOCALSTACK_VERSION
22+
docker run -d --rm --net=host --name=tensorflow-io-aws localstack/localstack:$LOCALSTACK_VERSION
23+
echo "Waiting for 10 secs until localstack is up and running"
24+
sleep 10
2625
echo "Localstack up"
2726
exit 0

tests/test_aws/docker-compose.yml

Lines changed: 0 additions & 12 deletions
This file was deleted.

tests/test_s3_eager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424

2525

2626
@pytest.mark.skipif(
27-
sys.platform in ("win32"),
28-
reason="TODO Localstack not setup properly on Windows yet",
27+
sys.platform in ("win32", "darwin"),
28+
reason="TODO Localstack not setup properly on macOS/Windows yet",
2929
)
3030
def test_read_file():
3131
"""Test case for reading S3"""

0 commit comments

Comments
 (0)