Update to haddock files for tensorflow-0.3 package (TensorFlow 2.3.0). #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackgnezdo
requested changes
Nov 13, 2020
|
Good catch. I had some issues with |
blackgnezdo
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised, this pull request completes the last thing remaining (excluding feature requests) for TensorFlow 2.3.0: the haddock files. There was also a minor edit to refer to 2.3.0-gpu and not 1.14.0-gpu in the README.
It would be very nice if those with the right permissions could push this upstream to Hackage.
For someone who has the spare cycles, it would be nice to push this up into Stackage as well:
https://github.com/commercialhaskell/stackage/blob/master/MAINTAINERS.md#adding-a-package
At this point in time, to add to Stackage, one must ensure compatibility with GHC 8.10.2 since that is what version Nightly is currently using. Special attention should be given to editing
debian-bootstrap.shto ensure thatlibtensorflow-2.3.0andprotoc-3.13.0is properly installed along with any other non-Haskell dependencies (seeci_build/Dockerfilefor the complete list).