Skip to content

Add gradient for slice function #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Conversation

erikabor
Copy link
Contributor

@erikabor erikabor commented Mar 6, 2019

I added the gradient for the slice function in tensorflow / haskell. Please check if the implementation is right. I used the version in python for template, see array_grad.py.

The CLA is signed by the manager of my company, Active Group GmbH. Please let me know if more info is needed (same as with pull requests by @rikvdkleij).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@blackgnezdo
Copy link
Contributor

Thanks for your contribution! I believe you need to troubleshoot the CLA with your company's signer:

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot Public version.

I did confirm that Active Group GmbH has a corporate CLA signed, so it's just your association with the CLA that's missing. Since you are saying @rikvdkleij already had it work, maybe figure out how your setup is different from his?

@erikabor
Copy link
Contributor Author

My POC added me to the group of authorized contributors.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkm3, do you think you could take a look?

Copy link
Contributor

@fkm3 fkm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@fkm3
Copy link
Contributor

fkm3 commented Mar 20, 2019

Could you sync this CL to resolve the merge conflicts and then I'll submit it? Thanks!

@erikabor
Copy link
Contributor Author

Issues should be resolved.

@fkm3 fkm3 dismissed blackgnezdo’s stale review March 26, 2019 20:30

Comments were addressed.

@fkm3 fkm3 merged commit 3cfd96e into tensorflow:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants