-
Notifications
You must be signed in to change notification settings - Fork 200
Add gradient for slice function #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your contribution! I believe you need to troubleshoot the CLA with your company's signer: Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot Public version. I did confirm that Active Group GmbH has a corporate CLA signed, so it's just your association with the CLA that's missing. Since you are saying @rikvdkleij already had it work, maybe figure out how your setup is different from his? |
My POC added me to the group of authorized contributors. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkm3, do you think you could take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could you sync this CL to resolve the merge conflicts and then I'll submit it? Thanks! |
7efe916
to
5721c6e
Compare
Issues should be resolved. |
I added the gradient for the slice function in tensorflow / haskell. Please check if the implementation is right. I used the version in python for template, see array_grad.py.
The CLA is signed by the manager of my company, Active Group GmbH. Please let me know if more info is needed (same as with pull requests by @rikvdkleij).