Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dataset continue method #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Dataset continue method #260

wants to merge 1 commit into from

Conversation

albertvillanova
Copy link
Contributor

Remove:

  • Dataset.continue method
  • fit steps_per_epoch parameter
  • evaluate steps parameter

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Oct 14, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@google-cla google-cla bot added the cla: yes CLA has been signed label Oct 14, 2020
MarkDaoust
MarkDaoust approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There used to be a performance penalty to doing it this way, you'd have to wait for the shuffle butffer to fill on each epoch. But that's been fixed.

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull labels Oct 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDaoust MarkDaoust MarkDaoust approved these changes

Assignees
No one assigned
Labels
cla: yes CLA has been signed ready to pull size:S CL Change Size: Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertvillanova @MarkDaoust @kokoro-team