#2066-doc-update-metrics-latest #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliyah123
requested review from
AakashKumarNain and
autoih
as code owners
|
@SSaishruthi @marload @autoih @AakashKumarNain You are owners of some files modified in this pull request. |
WindQAQ
reviewed
Sep 22, 2020
There was a problem hiding this comment.
Thanks for the contribution! Some requests:
- Can we canonicalize naming convention? Like
>>> y_true = np.foo(xxx)
>>> y_pred = np.foo(xxx)
>>> metric = tfa.metrics.bar(yyy)
>>> metric.update_state(y_true, y_pred)
>>> result = metric.result()
>>> result.numpy()- Some comments are not so meaningful in testable docstring. Like
# metric name: When users see the API page, they know this page is that metric. Therefore, we can also clean up this kind of comments in docstring in this PR!
Closed
WindQAQ
approved these changes
Sep 22, 2020
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* all_done * cohen_kapa_space * requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #2066