Added instructions to work on Addons on Windows. #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpmorgan
requested changes
Mar 7, 2020
CONTRIBUTING.md
Outdated
| * Docker desktop with Linux containers (code format, testing on linux, etc...) | ||
| * A local Python installation | ||
| * Bazel (if you want to compile custom ops on Windows, optional) | ||
| * [Visual Studio build tools 2017](https://devblogs.microsoft.com/cppblog/visual-studio-build-tools-now-include-the-vs2017-and-vs2015-msvc-toolsets/) |
There was a problem hiding this comment.
nit: I believe we're using MSVC2019 which aligns with TF-core:
https://www.tensorflow.org/install/source_windows#install_visual_c_build_tools_2019
seanpmorgan
approved these changes
Mar 7, 2020
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Added instructions to dev on Windows. * Added link. * Fix version. * Two instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have a windows Dockerfile but for the moment it's enough. With git bash on PATH and Docker desktop installed, everything worked out of the box.
Except the pesky file path starting with / being translated automatically by git bash when using a windows command (ex; docker desktop). MSYS_NO_PATHCONV=1 is here to disable it.
That was way less pain than what I imagined 😄
Fix #1134
There are no instructions to compile custom ops with windows but I think that people motivated enough to do that will be able to look at the github actions file to find out how it works.