Skip to content

Commit 6d0c920

Browse files
committed
Allow verify-generated-docs to use go modcache
I don't think we need to use an entirely separate GOPATH, thus forcing us to re-download modules every time we run `make` This was causing verify-generated-docs to fail locally since go will set its modcache as readonly and thus cause the cleanup "rm -rf" in this script to fail. In go1.14 or later we could use "-modcacherw" to stop making the modcache readonly but that bring me back to.. why do need an entirely separate GOPATH in the first place?
1 parent 7fdf3b2 commit 6d0c920

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

hack/verify-generated-docs.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ set -o pipefail
2121
CRT_DIR=$(pwd)
2222
VERIFY_TEMP=$(mktemp -d 2>/dev/null || mktemp -d -t k8s-community.XXXXXX)
2323
WORKING_DIR="${VERIFY_TEMP}/src/testgendocs"
24-
GOPATH="${VERIFY_TEMP}"
2524
mkdir -p "${WORKING_DIR}"
2625

2726
function cleanup {

0 commit comments

Comments
 (0)