Skip to content

Commit

Permalink
Allow verify-generated-docs to use go modcache
Browse files Browse the repository at this point in the history
I don't think we need to use an entirely separate GOPATH, thus forcing
us to re-download modules every time we run `make`

This was causing verify-generated-docs to fail locally since go will
set its modcache as readonly and thus cause the cleanup "rm -rf" in
this script to fail. In go1.14 or later we could use "-modcacherw"
to stop making the modcache readonly but that bring me back to.. why
do need an entirely separate GOPATH in the first place?
  • Loading branch information
spiffxp committed Aug 18, 2020
1 parent 7fdf3b2 commit 6d0c920
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion hack/verify-generated-docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ set -o pipefail
CRT_DIR=$(pwd)
VERIFY_TEMP=$(mktemp -d 2>/dev/null || mktemp -d -t k8s-community.XXXXXX)
WORKING_DIR="${VERIFY_TEMP}/src/testgendocs"
GOPATH="${VERIFY_TEMP}"
mkdir -p "${WORKING_DIR}"

function cleanup {
Expand Down

0 comments on commit 6d0c920

Please sign in to comment.