Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(make) golangci-lint install #141

Merged
merged 1 commit into from
May 12, 2022
Merged

chore(make) golangci-lint install #141

merged 1 commit into from
May 12, 2022

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented May 11, 2022

ref to: https://golangci-lint.run/usage/install/#local-installation

Previous there are some errors:

make lint                                                                                                                                        
curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b /usr/local/go/bin v1.23.6
golangci/golangci-lint info checking GitHub for tag 'v1.23.6'
golangci/golangci-lint info found version: 1.23.6 for v1.23.6/linux/amd64
golangci/golangci-lint info installed /usr/local/go/bin/golangci-lint
golangci/golangci-lint err this script is deprecated, please do not use it anymore. check https://github.com/goreleaser/godownloader/issues/207
WARN [runner] Can't run linter goanalysis_metalinter: assign: failed prerequisites: inspect@github.com/tensorchord/envd/pkg/unzip 
ERRO Running error: assign: failed prerequisites: inspect@github.com/tensorchord/envd/pkg/unzip 
make: *** [Makefile:102: lint] Error 3

Not sure if we need to fix the version to v1.23.6.

@kemingy kemingy requested a review from gaocegege May 11, 2022 14:17
@gaocegege gaocegege merged commit 7ef5c71 into main May 12, 2022
@gaocegege gaocegege deleted the fix_install_linter branch May 12, 2022 00:41
@gaocegege
Copy link
Member

I do not think we need to fix it in v1.23.6 .

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants