Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error handling #98

Merged
merged 5 commits into from
May 18, 2020
Merged

improve error handling #98

merged 5 commits into from
May 18, 2020

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented May 15, 2020 •
edited
Loading

Removes use of github.com/pkg/errors, returns error for NewDB(), and removes some panics.

@erikgrinaker erikgrinaker added the T:breaking Type: Breaking label May 15, 2020
@erikgrinaker erikgrinaker requested a review from tessr as a code owner May 15, 2020 16:51
@erikgrinaker erikgrinaker self-assigned this May 15, 2020
tac0turtle
tac0turtle approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@tac0turtle tac0turtle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well once tests pass

@erikgrinaker erikgrinaker changed the base branch from erik/iterator-error to master May 18, 2020 11:56
@erikgrinaker erikgrinaker added the S:automerge Status: Auto merge a pull request label May 18, 2020
@mergify mergify bot merged commit f191247 into master May 18, 2020
@tac0turtle tac0turtle deleted the erik/error-cleanups branch May 18, 2020 12:18
nddeluca pushed a commit to Kava-Labs/tm-db that referenced this pull request Jan 8, 2024
@thanethomson
Update to Go v1.21 (tendermint#98)
debd991 
* Update to Go v1.21

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix changelog entry formatting

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Update README with minimum Go version, and fix dependency reference

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@melekes melekes Awaiting requested review from melekes

@tessr tessr Awaiting requested review from tessr

Assignees

@erikgrinaker erikgrinaker

Labels
S:automerge Status: Auto merge a pull request T:breaking Type: Breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikgrinaker @tac0turtle