Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: Reduce "non-deterministic signature" noise when using tmkms #3583

Closed
mdyring opened this issue Apr 21, 2019 · 0 comments
Closed
Labels
C:consensus Component: Consensus good first issue Contributions Welcome!! T:observability Type: Observability

Comments

@mdyring
Copy link
Contributor

mdyring commented Apr 21, 2019

What happened:
When using tmkms against a single validator (but obviously also against multiple), the log is packed with

Apr 21 11:36:07 i-016ed17cbf9fe0bec gaiad[13908]: I[2019-04-21|11:36:07.288] Executed block                               module=state height=190523 validTxs=0 invalidTxs=0
Apr 21 11:36:07 i-016ed17cbf9fe0bec gaiad[13908]: I[2019-04-21|11:36:07.298] Committed state                              module=state height=190523 txs=0 appHash=2155AE6D685A2A78E7C3B702750528CDCAF466D7406185742D7F5F2275FDE796
Apr 21 11:36:07 i-016ed17cbf9fe0bec gaiad[13908]: E[2019-04-21|11:36:07.303] Error attempting to add vote                 module=consensus err="Existing vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 118810015DF9 @ 2019-04-21T11:36:06.95256089Z}; New vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 888D5294AEED @ 2019-04-21T11:36:06.885325351Z}: Non-deterministic signature"
Apr 21 11:36:07 i-016ed17cbf9fe0bec gaiad[13908]: E[2019-04-21|11:36:07.304] Error attempting to add vote                 module=consensus err="Existing vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 118810015DF9 @ 2019-04-21T11:36:06.95256089Z}; New vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 888D5294AEED @ 2019-04-21T11:36:06.885325351Z}: Non-deterministic signature"
Apr 21 11:36:07 i-016ed17cbf9fe0bec gaiad[13908]: E[2019-04-21|11:36:07.432] Error attempting to add vote                 module=consensus err="Existing vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 118810015DF9 @ 2019-04-21T11:36:06.95256089Z}; New vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 888D5294AEED @ 2019-04-21T11:36:06.885325351Z}: Non-deterministic signature"
Apr 21 11:36:07 i-016ed17cbf9fe0bec gaiad[13908]: E[2019-04-21|11:36:07.469] Error attempting to add vote                 module=consensus err="Existing vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 118810015DF9 @ 2019-04-21T11:36:06.95256089Z}; New vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 888D5294AEED @ 2019-04-21T11:36:06.885325351Z}: Non-deterministic signature"
Apr 21 11:36:07 i-016ed17cbf9fe0bec gaiad[13908]: E[2019-04-21|11:36:07.504] Error attempting to add vote                 module=consensus err="Existing vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 118810015DF9 @ 2019-04-21T11:36:06.95256089Z}; New vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 888D5294AEED @ 2019-04-21T11:36:06.885325351Z}: Non-deterministic signature"
Apr 21 11:36:07 i-016ed17cbf9fe0bec gaiad[13908]: E[2019-04-21|11:36:07.504] Error attempting to add vote                 module=consensus err="Existing vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 118810015DF9 @ 2019-04-21T11:36:06.95256089Z}; New vote: Vote{16:5B2ECC280D35 190523/00/2(Precommit) 695B9CC926DD 888D5294AEED @ 2019-04-21T11:36:06.885325351Z}: Non-deterministic signature"

What you expected to happen:
Less severe logging, after all Tendermint handles this gracefully.

Would recommend just logging with debug severity creating a special case for ErrVoteNonDeterministicSignature here

if err == ErrVoteHeightMismatch {

@melekes melekes added good first issue Contributions Welcome!! help wanted labels Apr 23, 2019
@xla xla changed the title Reduce "non-deterministic signature" noise when using tmkms consensus: Reduce "non-deterministic signature" noise when using tmkms Apr 23, 2019
@xla xla added C:consensus Component: Consensus T:observability Type: Observability labels Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:consensus Component: Consensus good first issue Contributions Welcome!! T:observability Type: Observability
Projects
None yet
Development

No branches or pull requests

3 participants