Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentinel error code #428

Open
4 tasks
jhernandezb opened this issue Jun 29, 2021 · 4 comments
Open
4 tasks

sentinel error code #428

jhernandezb opened this issue Jun 29, 2021 · 4 comments
Milestone
v2

Comments

@jhernandezb
Copy link

Summary of Bug

Sentinel errors must not start at 1 since this is reserved code.

See cosmos/cosmos-sdk#9598

Version

Steps to Reproduce

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jaybxyz
Copy link
Contributor

jaybxyz commented Jun 30, 2021

Good point. Thanks for brining it up.

  1. Must be greater than one, as a code value of one is reserved for internal errors.
  2. Must be unique within the module.

@lukerhoads
Copy link
Contributor

Would that mean just bumping everything up in the types/errors.go

@jaybxyz
Copy link
Contributor

jaybxyz commented Jul 7, 2021

This is something that needs to be fixed in the next version. We can bump the error code 1 instead of bumping everything up to minimize issues on client side.

@lukerhoads
Copy link
Contributor

Ahh yes much more efficient 💯

@dongsam dongsam added this to the v2 milestone Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

No branches or pull requests
4 participants
@dongsam @jhernandezb @jaybxyz @lukerhoads