Skip to content

Commit

Permalink
CI: Don't setup developer command prompt
Browse files Browse the repository at this point in the history
The action used to do it hasn't seen an update since 2021, and Ninja
builds are currently broken on Windows. Also, IIRC you don't need to
setup a VS developer environment since that should already be taken care
of by MSBuild.

Signed-off-by: Avery King <avery98@pm.me>
  • Loading branch information
generic-pers0n committed Aug 27, 2024
1 parent 84b719a commit 0f0ff98
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/cmake_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,6 @@ jobs:
p12-file-base64: ${{ secrets.APPLE_CERTIFICATE }}
p12-password: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}

# required for CMake to find Ninja
- name: "[Windows] Set up MSVC Developer Command Prompt"
if: runner.os == 'Windows'
uses: seanmiddleditch/gha-setup-vsdevenv@v4
with:
arch: ${{ matrix.config.arch }}

- name: Get Git commit of vcpkg submodule
run: echo VCPKG_COMMIT=$(git ls-tree HEAD vcpkg | awk '{print $3}') >> ${GITHUB_ENV}

Expand Down

0 comments on commit 0f0ff98

Please sign in to comment.