Async routing config propagation in deployment workflow #8570
+2,456
−811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
added a commit
to temporalio/api
that referenced
this pull request
Oct 31, 2025
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** - Added a monotonically increasing counter which shall be used by the history service when scheduling workflow/activity tasks. - Add an enum in the RoutingConfig which shall convey the routing config propagation status. This shall allow users to have a peek at the exact stage where an update, scheduled by a worker-versioning write API, has reached. <!-- Tell your future self why have you made these changes --> **Why?** - The main purpose of this is to resolve out-of-sync history and matching partitions when it comes to deciding how to route tasks <!-- Are there any breaking changes on binary or code level? --> None, just new fields and enums, no new APIs <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** temporalio/temporal#8570 --------- Co-authored-by: Carly de Frondeville <carly.defrondeville@temporal.io>
temporal-cicd bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
Oct 31, 2025
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** - Added a monotonically increasing counter which shall be used by the history service when scheduling workflow/activity tasks. - Add an enum in the RoutingConfig which shall convey the routing config propagation status. This shall allow users to have a peek at the exact stage where an update, scheduled by a worker-versioning write API, has reached. <!-- Tell your future self why have you made these changes --> **Why?** - The main purpose of this is to resolve out-of-sync history and matching partitions when it comes to deciding how to route tasks <!-- Are there any breaking changes on binary or code level? --> None, just new fields and enums, no new APIs <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** temporalio/temporal#8570 --------- Co-authored-by: Carly de Frondeville <carly.defrondeville@temporal.io>
# Conflicts: # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Describe what has changed in this PR.
Why?
Tell your future self why have you made these changes.
How did you test it?
Potential risks
Any change is risky. Identify all risks you are aware of. If none, remove this section.