Change error log of Tried to cancel a non-existing activity to debug
#1529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks, but I decided to make that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This changes the severity of the logging of
Tried to cancel a non-existing activityfrom error to debug.Why?
This is not an error condition, so it shouldn't be logged like one. We have an alert on error logs and this one comes up every now and again and is a distraction.
See Slack discussion: https://temporalio.slack.com/archives/C01DKSMU94L/p1726925750497729?thread_ts=1678096035.562979&cid=C01DKSMU94L
Checklist
It wasn't. I don't know how to reproduce the conditions that lead to this log.
I don't think so.