Skip to content

Update min proto version and fix gRPC optional dependency #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2023
Merged

Update min proto version and fix gRPC optional dependency #231

merged 1 commit into from
Jan 3, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Dec 16, 2022

What was changed

  • Update min protobuf dependency from 3.19 to 3.20 to include protocolbuffers/protobuf@0707f2e
  • Fix issue where grpcio was a dependency because the extra wasn't set right

Checklist

  1. Closes [Bug] Protobuf version 3.19 does not have ValueType enum wrapper #226
  2. Closes [Bug] grpcio not being treated as optional dependency #224

@cretz cretz requested a review from a team December 16, 2022 13:06
@cretz cretz marked this pull request as ready for review December 16, 2022 13:27
@cretz cretz merged commit 22e8d92 into temporalio:main Jan 3, 2023
@cretz cretz deleted the proto-grpc-update branch January 3, 2023 21:24
@cretz cretz mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcshane mmcshane mmcshane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Protobuf version 3.19 does not have ValueType enum wrapper [Bug] grpcio not being treated as optional dependency
2 participants
@cretz @mmcshane