Skip to content

Commit fd17cdf

Browse files
Remove unused metadata from client.create_schedule. Ensure WorkflowHistoryEventAsyncIterator.fetch_next_page uses the provided page_size override when called (#1247)
1 parent 6a3385b commit fd17cdf

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

temporalio/client.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,8 +1335,6 @@ async def create_schedule(
13351335
| (
13361336
temporalio.common.TypedSearchAttributes | temporalio.common.SearchAttributes
13371337
) = None,
1338-
static_summary: str | None = None,
1339-
static_details: str | None = None,
13401338
rpc_metadata: Mapping[str, str | bytes] = {},
13411339
rpc_timeout: timedelta | None = None,
13421340
) -> ScheduleHandle:
@@ -1355,12 +1353,6 @@ async def create_schedule(
13551353
attributes for a scheduled workflow are part of the scheduled
13561354
action. The dictionary form of this is DEPRECATED, use
13571355
:py:class:`temporalio.common.TypedSearchAttributes`.
1358-
static_summary: A single-line fixed summary for this workflow execution that may appear
1359-
in the UI/CLI. This can be in single-line Temporal markdown format.
1360-
static_details: General fixed details for this workflow execution that may appear in
1361-
UI/CLI. This can be in Temporal markdown format and can span multiple lines. This is
1362-
a fixed value on the workflow that cannot be updated. For details that can be
1363-
updated, use :py:meth:`temporalio.workflow.get_current_details` within the workflow.
13641356
rpc_metadata: Headers used on the RPC call. Keys here override
13651357
client-level RPC metadata keys.
13661358
rpc_timeout: Optional RPC deadline to set for the RPC call.
@@ -3419,7 +3411,7 @@ async def fetch_next_page(self, *, page_size: int | None = None) -> None:
34193411
workflow_id=self._input.id,
34203412
run_id=self._input.run_id or "",
34213413
),
3422-
maximum_page_size=self._input.page_size or 0,
3414+
maximum_page_size=page_size or self._input.page_size or 0,
34233415
next_page_token=self._next_page_token or b"",
34243416
wait_new_event=self._input.wait_new_event,
34253417
history_event_filter_type=temporalio.api.enums.v1.HistoryEventFilterType.ValueType(

0 commit comments

Comments
 (0)