File tree Expand file tree Collapse file tree 1 file changed +3
-1
lines changed Expand file tree Collapse file tree 1 file changed +3
-1
lines changed Original file line number Diff line number Diff line change @@ -201,10 +201,12 @@ async def drain_poll_queue(self) -> None:
201
201
202
202
# Only call this after run()/drain_poll_queue() have returned. This will not
203
203
# raise an exception.
204
+ # TODO(dan): based on the comment above it looks like the intention may have been to use
205
+ # return_exceptions=True
204
206
async def wait_all_completed (self ) -> None :
205
207
running_tasks = [v .task for v in self ._running_activities .values () if v .task ]
206
208
if running_tasks :
207
- await asyncio .gather (* running_tasks , return_exceptions = True )
209
+ await asyncio .gather (* running_tasks , return_exceptions = False )
208
210
209
211
def _handle_cancel_activity_task (
210
212
self , task_token : bytes , cancel : temporalio .bridge .proto .activity_task .Cancel
You can’t perform that action at this time.
0 commit comments