Skip to content

Commit f13fdc6

Browse files
committed
Revert change to wait_all_completed
1 parent a7a3812 commit f13fdc6

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

temporalio/worker/_activity.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,12 @@ async def drain_poll_queue(self) -> None:
201201

202202
# Only call this after run()/drain_poll_queue() have returned. This will not
203203
# raise an exception.
204+
# TODO(dan): based on the comment above it looks like the intention may have been to use
205+
# return_exceptions=True
204206
async def wait_all_completed(self) -> None:
205207
running_tasks = [v.task for v in self._running_activities.values() if v.task]
206208
if running_tasks:
207-
await asyncio.gather(*running_tasks, return_exceptions=True)
209+
await asyncio.gather(*running_tasks, return_exceptions=False)
208210

209211
def _handle_cancel_activity_task(
210212
self, task_token: bytes, cancel: temporalio.bridge.proto.activity_task.Cancel

0 commit comments

Comments
 (0)