Move compile binary into reusable step

Author: cretz

.github/workflows/ci.yml

@@ -77,15 +77,12 @@ jobs:
   # Compile the binaries and upload artifacts
   compile-binaries:
     strategy:
-      fail-fast: false
+      fail-fast: true
       matrix:
         include:
           - os: ubuntu-latest
             package-suffix: linux-amd64
             ci-arch: auto
-          - os: ubuntu-latest
-            package-suffix: linux-aarch64
-            ci-arch: aarch64
           - os: macos-latest
             package-suffix: macos-amd64
             ci-arch: auto
@@ -96,59 +93,21 @@ jobs:
           - os: windows-latest
             package-suffix: windows-amd64
             ci-arch: auto
-    runs-on: ${{ matrix.os }}
-    continue-on-error: true
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          submodules: recursive
-      - uses: actions/setup-python@v1
-        with:
-          python-version: "3.10"
+    uses: ./.github/workflows/compile-binary.yml
+    with:
+      os: ${{ matrix.os }}
+      package-suffix: ${{ matrix.package-suffix }}
+      ci-arch: ${{ matrix.ci-arch }}
+      rust-add-target: ${{ matrix.rust-add-target }}
 
-      # Install Rust locally for non-Linux (Linux uses an internal docker
-      # command to build with cibuildwheel which uses rustup install defined
-      # in pyproject.toml)
-      - if: ${{ runner.os != 'Linux' }}
-        uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-          target: ${{ matrix.rust-add-target }}
-      - if: ${{ runner.os != 'Linux' }}
-        uses: Swatinem/rust-cache@v1
-        with:
-          working-directory: temporalio/bridge
-
-      # Need QEMU for ARM build on Linux
-      - if: ${{ matrix.package-suffix == 'linux-aarch64' }}
-        uses: docker/setup-qemu-action@v1
-        with:
-          image: tonistiigi/binfmt:latest
-          platforms: arm64
-
-      # Prepare
-      - run: python -m pip install --upgrade wheel poetry poethepoet
-      - run: poetry install --no-root
-
-      # Add the source dist only for Linux x64 for now
-      - if: ${{ matrix.package-suffix == 'linux-amd64' }}
-        run: poetry build --format sdist
-
-      # Build and fix the wheel
-      - run: poetry run cibuildwheel --output-dir dist --arch ${{ matrix.ci-arch }}
-      - run: poe fix-wheel
-
-      # Do test only for ci-arch auto (i.e. local machine)
-      - if: ${{ matrix.ci-arch == 'auto' }}
-        uses: actions/setup-go@v2
-        with:
-          go-version: "1.18"
-      - if: ${{ matrix.ci-arch == 'auto' }}
-        run: poe test-dist-single
-
-      # Upload dist
-      - uses: actions/upload-artifact@v2
-        with:
-          name: packages-${{ matrix.package-suffix }}
-          path: dist
+  # We separate out Linux aarch64 because it is too slow to build every PR, so
+  # we only build on push. When we have a ARM Linux runner or invest the time
+  # into not using QEMU, we may move back.
+  compile-binaries-linux-aarch64:
+    if: ${{ github.event_name != 'pull_request' }}
+    uses: ./.github/workflows/compile-binary.yml
+    with:
+      os: ubuntu-latest
+      package-suffix: linux-aarch64
+      ci-arch: aarch64
 

.github/workflows/compile-binary.yml

@@ -0,0 +1,72 @@
+name: Compile Binary
+on:
+  workflow_call:
+    inputs:
+      os:
+        required: true
+        type: string
+      package-suffix:
+        required: true
+        type: string
+      ci-arch:
+        required: true
+        type: string
+      rust-add-target:
+        type: string
+
+jobs:
+  compile-binaries:
+    runs-on: ${{ inputs.os }}
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - uses: actions/setup-python@v1
+        with:
+          python-version: "3.10"
+
+      # Install Rust locally for non-Linux (Linux uses an internal docker
+      # command to build with cibuildwheel which uses rustup install defined
+      # in pyproject.toml)
+      - if: ${{ runner.os != 'Linux' }}
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          target: ${{ inputs.rust-add-target }}
+      - if: ${{ runner.os != 'Linux' }}
+        uses: Swatinem/rust-cache@v1
+        with:
+          working-directory: temporalio/bridge
+
+      # Need QEMU for ARM build on Linux
+      - if: ${{ inputs.package-suffix == 'linux-aarch64' }}
+        uses: docker/setup-qemu-action@v1
+        with:
+          image: tonistiigi/binfmt:latest
+          platforms: arm64
+
+      # Prepare
+      - run: python -m pip install --upgrade wheel poetry poethepoet
+      - run: poetry install --no-root
+
+      # Add the source dist only for Linux x64 for now
+      - if: ${{ inputs.package-suffix == 'linux-amd64' }}
+        run: poetry build --format sdist
+
+      # Build and fix the wheel
+      - run: poetry run cibuildwheel --output-dir dist --arch ${{ inputs.ci-arch }}
+      - run: poe fix-wheel
+
+      # Do test only for ci-arch auto (i.e. local machine)
+      - if: ${{ inputs.ci-arch == 'auto' }}
+        uses: actions/setup-go@v2
+        with:
+          go-version: "1.18"
+      - if: ${{ inputs.ci-arch == 'auto' }}
+        run: poe test-dist-single
+
+      # Upload dist
+      - uses: actions/upload-artifact@v2
+        with:
+          name: packages-${{ inputs.package-suffix }}
+          path: dist