In-workflow signal/query handler setting

Author: cretz

pyproject.toml

@@ -88,7 +88,7 @@ asyncio_mode = "auto"
 log_cli = true
 log_cli_level = "INFO"
 log_cli_format = "%(asctime)s [%(levelname)8s] %(message)s (%(filename)s:%(lineno)s)"
-timeout = 120
+timeout = 300
 timeout_func_only = true
 
 [tool.isort]

temporalio/worker/workflow.py

@@ -32,7 +32,7 @@
 logger = logging.getLogger(__name__)
 
 # Set to true to log all activations and completions
-LOG_PROTOS = False
+LOG_PROTOS = True
 
 # Maximum amount of seconds a thread can run a workflow activation before a
 # deadlock is assumed
@@ -118,10 +118,9 @@ async def _handle_activation(
     ) -> None:
         global LOG_PROTOS, DEADLOCK_TIMEOUT_SECONDS
 
-        # Build completion
-        completion: Optional[
-            temporalio.bridge.proto.workflow_completion.WorkflowActivationCompletion
-        ] = None
+        # Build default success completion (e.g. remove-job-only activations)
+        completion = temporalio.bridge.proto.workflow_completion.WorkflowActivationCompletion()
+        completion.successful.SetInParent()
         try:
             # Decode the activation if there's a codec
             if self._data_converter.payload_codec:
@@ -165,10 +164,6 @@ async def _handle_activation(
                 f"Failed handling activation on workflow with run ID {act.run_id}"
             )
             # Set completion failure
-            if not completion:
-                completion = (
-                    temporalio.bridge.proto.workflow_completion.WorkflowActivationCompletion()
-                )
             completion.failed.failure.SetInParent()
             try:
                 temporalio.exceptions.apply_exception_to_failure(
@@ -183,12 +178,6 @@ async def _handle_activation(
                 completion.failed.failure.message = (
                     f"Failed converting activation exception: {inner_err}"
                 )
-        # Make sure a completion always exists (technically will only be absent
-        # on remove-job-only activations)
-        if not completion:
-            completion = (
-                temporalio.bridge.proto.workflow_completion.WorkflowActivationCompletion()
-            )
 
         # Encode the completion if there's a codec
         if self._data_converter.payload_codec: