Skip to content

Commit a99fea2

Browse files
committed
Kwarg
1 parent 8f6dad2 commit a99fea2

File tree

4 files changed

+31
-18
lines changed

4 files changed

+31
-18
lines changed

temporalio/client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ def _init_from_config(self, config: ClientConfig):
262262
for interceptor in reversed(list(self._config["interceptors"])):
263263
self._impl = interceptor.intercept_client(self._impl)
264264

265-
def config(self, active_config: bool = False) -> ClientConfig:
265+
def config(self, *, active_config: bool = False) -> ClientConfig:
266266
"""Config, as a dictionary, used to create this client.
267267
268268
Args:
@@ -4295,7 +4295,7 @@ async def _to_proto(
42954295
await _apply_headers(
42964296
self.headers,
42974297
action.start_workflow.header.fields,
4298-
client.config(True)["header_codec_behavior"]
4298+
client.config(active_config=True)["header_codec_behavior"]
42994299
== HeaderCodecBehavior.CODEC
43004300
and not self._from_raw,
43014301
client.data_converter.payload_codec,
@@ -6923,7 +6923,7 @@ async def _apply_headers(
69236923
await _apply_headers(
69246924
source,
69256925
dest,
6926-
self._client.config(True)["header_codec_behavior"]
6926+
self._client.config(active_config=True)["header_codec_behavior"]
69276927
== HeaderCodecBehavior.CODEC,
69286928
self._client.data_converter.payload_codec,
69296929
)

temporalio/worker/_replayer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def __init__(
9292
if not self._config["workflows"]:
9393
raise ValueError("At least one workflow must be specified")
9494

95-
def config(self, active_config: bool = False) -> ReplayerConfig:
95+
def config(self, *, active_config: bool = False) -> ReplayerConfig:
9696
"""Config, as a dictionary, used to create this replayer.
9797
9898
Args:

temporalio/worker/_worker.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ def _init_from_config(self, client: temporalio.client.Client, config: WorkerConf
409409
)
410410

411411
# Prepend applicable client interceptors to the given ones
412-
client_config = config["client"].config(True)
412+
client_config = config["client"].config(active_config=True)
413413
interceptors_from_client = cast(
414414
List[Interceptor],
415415
[i for i in client_config["interceptors"] if isinstance(i, Interceptor)],
@@ -623,7 +623,7 @@ def check_activity(activity):
623623
),
624624
)
625625

626-
def config(self, active_config: bool = False) -> WorkerConfig:
626+
def config(self, *, active_config: bool = False) -> WorkerConfig:
627627
"""Config, as a dictionary, used to create this worker.
628628
629629
Args:

tests/test_plugins.py

Lines changed: 25 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ async def test_worker_plugin_basic_config(client: Client) -> None:
150150
activities=[never_run_activity],
151151
plugins=[MyWorkerPlugin()],
152152
)
153-
task_queue = worker.config(True).get("task_queue")
153+
task_queue = worker.config(active_config=True).get("task_queue")
154154
assert task_queue is not None and task_queue.startswith("replaced_queue")
155155

156156
# Test client plugin propagation to worker plugins
@@ -160,7 +160,7 @@ async def test_worker_plugin_basic_config(client: Client) -> None:
160160
worker = Worker(
161161
client, task_queue="queue" + str(uuid.uuid4()), activities=[never_run_activity]
162162
)
163-
task_queue = worker.config(True).get("task_queue")
163+
task_queue = worker.config(active_config=True).get("task_queue")
164164
assert task_queue is not None and task_queue.startswith("combined")
165165

166166
# Test both. Client propagated plugins are called first, so the worker plugin overrides in this case
@@ -170,7 +170,7 @@ async def test_worker_plugin_basic_config(client: Client) -> None:
170170
activities=[never_run_activity],
171171
plugins=[MyWorkerPlugin()],
172172
)
173-
task_queue = worker.config(True).get("task_queue")
173+
task_queue = worker.config(active_config=True).get("task_queue")
174174
assert task_queue is not None and task_queue.startswith("replaced_queue")
175175

176176

@@ -202,7 +202,8 @@ async def test_worker_sandbox_restrictions(client: Client) -> None:
202202
assert (
203203
"my_module"
204204
in cast(
205-
SandboxedWorkflowRunner, worker.config(True).get("workflow_runner")
205+
SandboxedWorkflowRunner,
206+
worker.config(active_config=True).get("workflow_runner"),
206207
).restrictions.passthrough_modules
207208
)
208209

@@ -276,8 +277,11 @@ async def test_replay(client: Client) -> None:
276277
)
277278
await handle.result()
278279
replayer = Replayer(workflows=[], plugins=[plugin])
279-
assert len(replayer.config(True).get("workflows") or []) == 1
280-
assert replayer.config(True).get("data_converter") == pydantic_data_converter
280+
assert len(replayer.config(active_config=True).get("workflows") or []) == 1
281+
assert (
282+
replayer.config(active_config=True).get("data_converter")
283+
== pydantic_data_converter
284+
)
281285

282286
await replayer.replay_workflow(await handle.fetch_history())
283287

@@ -303,19 +307,28 @@ async def test_simple_plugins(client: Client) -> None:
303307
plugins=[plugin],
304308
)
305309
# On a sequence, a value is appended
306-
assert worker.config(True).get("workflows") == [HelloWorkflow, HelloWorkflow2]
310+
assert worker.config(active_config=True).get("workflows") == [
311+
HelloWorkflow,
312+
HelloWorkflow2,
313+
]
307314

308315
# Test with plugin registered in client
309316
worker = Worker(
310317
new_client,
311318
task_queue="queue" + str(uuid.uuid4()),
312319
activities=[never_run_activity],
313320
)
314-
assert worker.config(True).get("workflows") == [HelloWorkflow2]
321+
assert worker.config(active_config=True).get("workflows") == [HelloWorkflow2]
315322

316323
replayer = Replayer(workflows=[HelloWorkflow], plugins=[plugin])
317-
assert replayer.config(True).get("data_converter") == pydantic_data_converter
318-
assert replayer.config(True).get("workflows") == [HelloWorkflow, HelloWorkflow2]
324+
assert (
325+
replayer.config(active_config=True).get("data_converter")
326+
== pydantic_data_converter
327+
)
328+
assert replayer.config(active_config=True).get("workflows") == [
329+
HelloWorkflow,
330+
HelloWorkflow2,
331+
]
319332

320333

321334
async def test_simple_plugins_callables(client: Client) -> None:
@@ -350,7 +363,7 @@ def converter(old: Optional[DataConverter]):
350363
activities=[never_run_activity],
351364
plugins=[plugin],
352365
)
353-
assert worker.config(True).get("workflows") == []
366+
assert worker.config(active_config=True).get("workflows") == []
354367

355368

356369
class MediumPlugin(SimplePlugin):
@@ -371,5 +384,5 @@ async def test_medium_plugin(client: Client) -> None:
371384
plugins=[plugin],
372385
workflows=[HelloWorkflow],
373386
)
374-
task_queue = worker.config(True).get("task_queue")
387+
task_queue = worker.config(active_config=True).get("task_queue")
375388
assert task_queue is not None and task_queue.startswith("override")

0 commit comments

Comments
 (0)