Skip to content

Commit 37c8155

Browse files
committed
Use new CLI RC to avoid persistence bug
1 parent 30e00ae commit 37c8155

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ async def env(env_type: str) -> AsyncGenerator[WorkflowEnvironment, None]:
115115
"system.enableDeploymentVersions=true",
116116
],
117117
# TODO: Remove after next CLI release
118-
dev_server_download_version="v1.3.1-priority.0",
118+
dev_server_download_version="v1.3.1-persistence-fix.0",
119119
)
120120
elif env_type == "time-skipping":
121121
env = await WorkflowEnvironment.start_time_skipping()

tests/worker/test_worker.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -274,6 +274,17 @@ async def test_can_run_resource_based_worker(client: Client, env: WorkflowEnviro
274274
# Ensure we can assume defaults when specifying only some options
275275
activity_config=ResourceBasedSlotConfig(minimum_slots=1),
276276
)
277+
prom_addr = f"127.0.0.1:{find_free_port()}"
278+
runtime = Runtime(
279+
telemetry=TelemetryConfig(
280+
metrics=PrometheusConfig(bind_address=prom_addr),
281+
)
282+
)
283+
client = await Client.connect(
284+
client.service_client.config.target_host,
285+
namespace=client.namespace,
286+
runtime=runtime,
287+
)
277288
async with new_worker(
278289
client,
279290
WaitOnSignalWorkflow,
@@ -285,9 +296,16 @@ async def test_can_run_resource_based_worker(client: Client, env: WorkflowEnviro
285296
id=f"resource-based-{uuid.uuid4()}",
286297
task_queue=w.task_queue,
287298
)
299+
# Resource metrics get emitted on a 1 second tick
300+
await asyncio.sleep(1)
288301
await wf1.signal(WaitOnSignalWorkflow.my_signal, "finish")
289302
await wf1.result()
290303

304+
with urlopen(url=f"http://{prom_addr}/metrics") as f:
305+
prom_str: str = f.read().decode("utf-8")
306+
# verify resource metrics are being emitted
307+
assert "resource_slots_mem_usage" in prom_str
308+
291309

292310
async def test_can_run_composite_tuner_worker(client: Client, env: WorkflowEnvironment):
293311
resource_based_options = ResourceBasedTunerConfig(0.5, 0.5)

0 commit comments

Comments
 (0)