Skip to content

Fix flake in testNullTaskReleasesSlot #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Fix flake in testNullTaskReleasesSlot #2583

merged 1 commit into from
Jul 7, 2025

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Fix flake in testNullTaskReleasesSlot. testNullTaskReleasesSlot Was sometime failing locally if the poller got called more then once, so this assertion would fail

assertEquals(1, slotSupplierInner.reservedCount.get());

Since 2 or more slots would have gotten reserved by that point. There is nothing wrong with that so relaxing the assertion.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner July 5, 2025 23:33
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit fd648d1 into temporalio:master Jul 7, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz