Skip to content

Updated the docs for IdReusePolicy property #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

petrkoutnycz
Copy link
Contributor

What was changed

Docs for IdReusePolicy property in WorkflowOptions and ChildWorkflowOptions.

Why?

Previous wording was misleading as it did not explicitly state it applies to "closed" workflows.

@petrkoutnycz
Copy link
Contributor Author

@cretz any take on this, please? :-)

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor suggestion to capitalize ID, otherwise LGTM, thanks!

Co-authored-by: Chad Retz <chad.retz@gmail.com>
@petrkoutnycz
Copy link
Contributor Author

Very minor suggestion to capitalize ID, otherwise LGTM, thanks!

Fixed

@petrkoutnycz petrkoutnycz requested a review from cretz February 3, 2025 14:05
Co-authored-by: Chad Retz <chad.retz@gmail.com>
@cretz cretz merged commit 69dfe5a into temporalio:main Feb 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants