Added FirstExecutionRunId to WorkflowInfo (#516)

Author: maciejdudko

src/Temporalio/Worker/WorkflowInstance.cs

@@ -183,6 +183,7 @@ public WorkflowInstance(WorkflowInstanceDetails details)
                 ContinuedRunId: NonEmptyOrNull(start.ContinuedFromExecutionRunId),
                 CronSchedule: NonEmptyOrNull(start.CronSchedule),
                 ExecutionTimeout: start.WorkflowExecutionTimeout?.ToTimeSpan(),
+                FirstExecutionRunId: start.FirstExecutionRunId,
                 Headers: start.Headers,
                 LastFailure: lastFailure,
                 LastResult: lastResult,

src/Temporalio/Workflows/WorkflowInfo.cs

@@ -12,6 +12,7 @@ namespace Temporalio.Workflows
     /// <param name="ContinuedRunId">Run ID if this was continued.</param>
     /// <param name="CronSchedule">Cron schedule if applicable.</param>
     /// <param name="ExecutionTimeout">Execution timeout for the workflow.</param>
+    /// <param name="FirstExecutionRunId">The very first run ID the workflow ever had, following continuation chains.</param>
     /// <param name="Headers">Headers from when the workflow was started.</param>
     /// <param name="LastFailure">Failure if this workflow run is a continuation of a failure.</param>
     /// <param name="LastResult">Successful result if this workflow is a continuation of a success.</param>
@@ -38,6 +39,7 @@ public record WorkflowInfo(
         string? ContinuedRunId,
         string? CronSchedule,
         TimeSpan? ExecutionTimeout,
+        string FirstExecutionRunId,
         IReadOnlyDictionary<string, Api.Common.V1.Payload>? Headers,
         Exception? LastFailure,
         IReadOnlyCollection<IRawValue>? LastResult,
@@ -64,6 +66,7 @@ public record WorkflowInfo(
         {
             ["Attempt"] = Attempt,
             ["Namespace"] = Namespace,
+            ["FirstExecutionRunId"] = FirstExecutionRunId,
             ["RunId"] = RunId,
             ["TaskQueue"] = TaskQueue,
             ["WorkflowId"] = WorkflowId,

tests/Temporalio.Tests/Client/WorkflowHandleTests.cs

@@ -18,15 +18,24 @@ public async Task GetResultAsync_ContinueAsNew_ProperlyFollowed()
     {
         // Start with a single round of continue as new
         var arg = new KSWorkflowParams(
-            new KSAction(ContinueAsNew: new(WhileAboveZero: 1, Result: "Some String")));
+            new KSAction(ContinueAsNew: new(WhileAboveZero: 1)));
         var handle = await Client.StartWorkflowAsync(
             (IKitchenSinkWorkflow wf) => wf.RunAsync(arg),
             new(id: $"workflow-{Guid.NewGuid()}", taskQueue: Env.KitchenSinkWorkerTaskQueue));
 
         // Check result with and without following
-        Assert.Equal("Some String", await handle.GetResultAsync());
-        await Assert.ThrowsAsync<Exceptions.WorkflowContinuedAsNewException>(
-            async () => await handle.GetResultAsync(followRuns: false));
+        Assert.Equal(handle.ResultRunId, await handle.GetResultAsync());
+        try
+        {
+            await handle.GetResultAsync(followRuns: false);
+            Assert.Fail("Should have thrown an exception");
+        }
+        catch (Exceptions.WorkflowContinuedAsNewException ex)
+        {
+            Assert.NotEqual(handle.ResultRunId, ex.NewRunId);
+            var continuedHandle = Client.GetWorkflowHandle<IKitchenSinkWorkflow, string>(handle.Id, runId: ex.NewRunId);
+            Assert.Equal(handle.ResultRunId, await continuedHandle.GetResultAsync(followRuns: false));
+        }
     }
 
     [Fact]

tests/Temporalio.Tests/IKitchenSinkWorkflow.cs

@@ -70,8 +70,7 @@ public record KSErrorAction(
     [property: JsonPropertyName("is_benign")] bool IsBenign = false);
 
 public record KSContinueAsNewAction(
-    [property: JsonPropertyName("while_above_zero")] int? WhileAboveZero = null,
-    [property: JsonPropertyName("result")] object? Result = null);
+    [property: JsonPropertyName("while_above_zero")] int? WhileAboveZero = null);
 
 public record KSSleepAction(
     [property: JsonPropertyName("millis")] long Millis);

tests/Temporalio.Tests/KitchenSinkWorkflow.cs

@@ -104,7 +104,7 @@ action with
                 throw Workflow.CreateContinueAsNewException(
                     (IKitchenSinkWorkflow wf) => wf.RunAsync(args));
             }
-            return (true, action.ContinueAsNew.Result);
+            return (true, Workflow.Info.FirstExecutionRunId);
         }
         else if (action.Sleep != null)
         {