Fixed fakeProgress activity heartbeat #363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ssrohit
force-pushed
the
activity-heartbeat
branch
from
d58423c
to
1509737
Compare
|
This PR can close this issue #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Changed activity(long-running activity) to heartbeat immediately
Why?
If the activity heartbeats after operation such as DB insertion or reads, when failed the activity retries from a progress point which is success, which results in inconsistency.
Closes - fix heartbeating in fakeProgress activity #366
How was this tested:
I have tested this in my personal project, one can test and replicate this by data insertion in the fakeProgress activity instead of
await sleep(...)code line.Any docs updates needed?
Yes, code sample in the documentation should be updated and this should be described for better understanding.
https://docs.temporal.io/dev-guide/typescript/features#activity-heartbeats