-
Notifications
You must be signed in to change notification settings - Fork 74
Expense example #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Expense example #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor things, nothing technically blocking
f"{EXPENSE_SERVER_HOST_PORT}/create", | ||
params={"is_api_call": "true", "id": expense_id}, | ||
) | ||
response.raise_for_status() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically 4xx is probably a ApplicationError
with non_retryable=True
, but that's a bit pedantic. But with this setup, an activity that, say, has invalid auth will retry forever
What was changed
Ported the expense example from Go to Python
Why?
Demonstrate human-in-the-loop processing and asynchronous activity completion
Checklist
Closes N/A
How was this tested:
Includes tests
Any docs updates needed?
README is updated