Skip to content

Expense example #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Expense example #201

wants to merge 18 commits into from

Conversation

jssmith
Copy link
Contributor

@jssmith jssmith commented Jun 23, 2025

What was changed

Ported the expense example from Go to Python

Why?

Demonstrate human-in-the-loop processing and asynchronous activity completion

Checklist

  1. Closes N/A

  2. How was this tested:
    Includes tests

  3. Any docs updates needed?
    README is updated

@jssmith jssmith requested a review from a team as a code owner June 23, 2025 16:47
@jssmith jssmith requested a review from tconley1428 June 23, 2025 16:47
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor things, nothing technically blocking

f"{EXPENSE_SERVER_HOST_PORT}/create",
params={"is_api_call": "true", "id": expense_id},
)
response.raise_for_status()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically 4xx is probably a ApplicationError with non_retryable=True, but that's a bit pedantic. But with this setup, an activity that, say, has invalid auth will retry forever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants