Properly skip infrequent polling test on time-skipping server #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuandrew
approved these changes
May 12, 2025
dandavison
reviewed
May 15, 2025
| @@ -10,7 +10,7 @@ | |||
|
|
|||
|
|
|||
| async def test_infrequent_polling_workflow(client: Client, env: WorkflowEnvironment): | |||
| if not env.supports_time_skipping: | |||
| if env.supports_time_skipping: | |||
| pytest.skip("Too slow to test with time-skipping disabled") | |||
There was a problem hiding this comment.
The boolean condition and the message don't seem to jointly make sense any longer?
There was a problem hiding this comment.
Hrmm, maybe I misunderstood the situation here and we are wanting to only run this test with time skipping and it's still too slow even with time skipping. Will look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Properly skip infrequent polling test on time-skipping server
Checklist