Dan feedback

Author: drewhoskins-temporal

polling/infrequent/activities.py

@@ -1,16 +1,9 @@
-from dataclasses import dataclass
-
 from temporalio import activity
 
+from polling.infrequent.compose_greeting_input import ComposeGreetingInput
 from polling.test_service import TestService
 
 
-@dataclass
-class ComposeGreetingInput:
-    greeting: str
-    name: str
-
-
 @activity.defn
 async def compose_greeting(input: ComposeGreetingInput) -> str:
     test_service = TestService()

polling/infrequent/compose_greeting_input.py

@@ -0,0 +1,7 @@
+from dataclasses import dataclass
+
+
+@dataclass
+class ComposeGreetingInput:
+    greeting: str
+    name: str

polling/test_service.py

@@ -1,9 +1,12 @@
+from polling.infrequent.compose_greeting_input import ComposeGreetingInput
+
+
 class TestService:
     def __init__(self):
         self.error_attempts = 5
 
     async def get_service_result(self, input: ComposeGreetingInput, attempt: int):
         print(f"Attempt {attempt} of {self.error_attempts} to invoke service")
-        if attempt % self.error_attempts == 0:
+        if attempt > self.error_attempts:
             return f"{input.greeting}, {input.name}!"
         raise Exception("service is down")