Merge pull request #1024 from telerik/vladimirov/fix-default-help

Fix showing default help (from index.md)

Author: rosen-vladimirov

services/help-service.ts

@@ -119,19 +119,19 @@ export class HelpService implements IHelpService {
 	}
 
 	private async convertCommandNameToFileName(commandName: string): Promise<string> {
-		const defaultCommandMatch = commandName.match(/(\w+?)\|\*/);
+		const defaultCommandMatch = commandName && commandName.match(/(\w+?)\|\*/);
 		if (defaultCommandMatch) {
 			this.$logger.trace("Default command found. Replace current command name '%s' with '%s'.", commandName, defaultCommandMatch[1]);
 			commandName = defaultCommandMatch[1];
 		}
 
 		const availableCommands = this.$injector.getRegisteredCommandsNames(true).sort();
 		this.$logger.trace("List of registered commands: %s", availableCommands.join(", "));
-		if (!_.includes(availableCommands, commandName)) {
+		if (commandName && !_.includes(availableCommands, commandName)) {
 			this.$errors.failWithoutHelp("Unknown command '%s'. Try '$ %s help' for a full list of supported commands.", commandName, this.$staticConfig.CLIENT_NAME.toLowerCase());
 		}
 
-		return commandName.replace(/\|/g, "-") || "index";
+		return (commandName && commandName.replace(/\|/g, "-")) || "index";
 	}
 
 	private tryOpeningSelectedPage(htmlPage: string): boolean {

test/unit-tests/services/help-service.ts

@@ -419,5 +419,20 @@ and another one`
 			const output = injector.resolve("logger").output;
 			assert.isTrue(output.indexOf("bla param1 param2 end") >= 0);
 		});
+
+		_.each(["", null, undefined], (commandName: string) => {
+			it("shows index help when command is not specified", async () => {
+				const injector = createTestInjector();
+				injector.register("fs", {
+					enumerateFilesInDirectorySync: (path: string) => ["index.md"],
+					readText: () => "index data is read"
+				});
+
+				const helpService = injector.resolve<IHelpService>("helpService");
+				await helpService.showCommandLineHelp(commandName);
+				const output = injector.resolve("logger").output;
+				assert.isTrue(output.indexOf("index data is read") >= 0);
+			});
+		});
 	});
 });