Skip to content

Commit d0a9c31

Browse files
GermanAizekteleprint-me
authored andcommitted
grammar, json, llama: replace push on emplace if it possible (ggml-org#7273)
1 parent a8d948c commit d0a9c31

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

common/grammar-parser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ namespace grammar_parser {
2626

2727
static uint32_t get_symbol_id(parse_state & state, const char * src, size_t len) {
2828
uint32_t next_id = static_cast<uint32_t>(state.symbol_ids.size());
29-
auto result = state.symbol_ids.insert(std::make_pair(std::string(src, len), next_id));
29+
auto result = state.symbol_ids.emplace(std::string(src, len), next_id);
3030
return result.first->second;
3131
}
3232

common/json-schema-to-grammar.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ class SchemaConverter {
272272
if (literal.empty()) {
273273
return false;
274274
}
275-
ret.push_back(std::make_pair(literal, true));
275+
ret.emplace_back(literal, true);
276276
literal.clear();
277277
return true;
278278
};
@@ -298,7 +298,7 @@ class SchemaConverter {
298298
while (i < length) {
299299
char c = sub_pattern[i];
300300
if (c == '.') {
301-
seq.push_back(std::make_pair(get_dot(), false));
301+
seq.emplace_back(get_dot(), false);
302302
i++;
303303
} else if (c == '(') {
304304
i++;
@@ -307,7 +307,7 @@ class SchemaConverter {
307307
_warnings.push_back("Unsupported pattern syntax");
308308
}
309309
}
310-
seq.push_back(std::make_pair("(" + to_rule(transform()) + ")", false));
310+
seq.emplace_back("(" + to_rule(transform()) + ")", false);
311311
} else if (c == ')') {
312312
i++;
313313
if (start > 0 && sub_pattern[start - 1] != '(') {
@@ -331,9 +331,9 @@ class SchemaConverter {
331331
}
332332
square_brackets += ']';
333333
i++;
334-
seq.push_back(std::make_pair(square_brackets, false));
334+
seq.emplace_back(square_brackets, false);
335335
} else if (c == '|') {
336-
seq.push_back(std::make_pair("|", false));
336+
seq.emplace_back("|", false);
337337
i++;
338338
} else if (c == '*' || c == '+' || c == '?') {
339339
seq.back() = std::make_pair(to_rule(seq.back()) + c, false);
@@ -417,7 +417,7 @@ class SchemaConverter {
417417
}
418418
}
419419
if (!literal.empty()) {
420-
seq.push_back(std::make_pair(literal, true));
420+
seq.emplace_back(literal, true);
421421
}
422422
}
423423
}

llama.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17024,13 +17024,13 @@ static size_t llama_state_seq_get_data_internal(struct llama_context * ctx, llam
1702417024
}
1702517025
else {
1702617026
if (cell_range_begin != kv_self.size) {
17027-
cell_ranges.push_back({ cell_range_begin, i });
17027+
cell_ranges.emplace_back(cell_range_begin, i);
1702817028
cell_range_begin = kv_self.size;
1702917029
}
1703017030
}
1703117031
}
1703217032
if (cell_range_begin != kv_self.size) {
17033-
cell_ranges.push_back({ cell_range_begin, kv_self.size });
17033+
cell_ranges.emplace_back(cell_range_begin, kv_self.size);
1703417034
}
1703517035

1703617036
// DEBUG CHECK: Sum of cell counts in ranges should equal the total cell count

0 commit comments

Comments
 (0)