Copy-pasting from Firefox downloads image again #10564

arisudesu · 2021-03-18T22:36:49Z

When copying images from firefox to telegram, the latter does not insert the image data as a photo, but instead downloads the same image by url. This wastes twice the amount of traffic on re-downloading the picture.
In addition, this creates a problem when copying pictures from sites protected by authorization, because telegram does not have the same cookies - instead, it downloads the 403 page as a file and tries to send it.

Steps to reproduce (example 1)

Take, for example, large photo from wikipedia (~80 MB): https://upload.wikimedia.org/wikipedia/commons/e/ec/Mona_Lisa%2C_by_Leonardo_da_Vinci%2C_from_C2RMF_retouched.jpg
Right-click it and select "Copy image"
Paste it into telegram input field
Observe how long it is pasted

Steps to reproduce (example 2)

(You'll need account on pixiv.net - it's free)

Navigate to a pixiv image, e.g.: https://www.pixiv.net/en/artworks/79037838
Click on the artwork to enlarge it
Right-click it and select "Copy image"
Paste it into telegram input field
Image is not copy-pasted, instead a 146 bytes file is prompted to send, which contains "403 Forbidden" message

Expected behaviour

Image is copy-pasted without redownload.

Actual behaviour

Telegram forces it to download again.

Configuration

Operating system: Windows 10 20H2

Version of Telegram Desktop: 2.6.1

Installation source (Linux Only) - the official website / GitHub releases / flatpak / snap / distribution package: -

Used theme: -

ilya-fedin · 2021-03-19T10:13:06Z

This is not downloading, tdesktop doesn't have code to download a picture from URL when pasting...

arisudesu · 2021-03-19T11:17:24Z

Then please explain what's going on? Why is the file containing the html error copied to telegram, while the downloaded image is displayed in the browser? This is evidence that the telegram does not use the already downloaded picture.

Another observation is that this does not happen in chrome, edge.

RememberTheAir · 2021-03-19T12:27:26Z

Both the examples you described don't seem to suggest that the picture is downloaded again by tdesktop

Example 1: pasting the image takes some time because the file is very large. If after pasting the image you click on "cancel", you'll see that tdesktop pasted the file uri it was sending in the input box, that is stored in some firefox cache directory (in my case it's file:///C:/Users/REDACTED/AppData/Local/Temp/Mona_Lisa,_by_Leonardo_da_Vinci,_from_C2RMF_retouched.jpg. The image is not downloaded by tdesktop again

Example 2: no idea why it sends that file instead of the picture, but apparently copy-pasting that image doesn't work in every software that supports this action (eg. try to paste it in an email)

ilya-fedin · 2021-03-19T12:40:51Z

What "file instead of the picture" are you both talking about? 🤔

RememberTheAir · 2021-03-19T12:49:28Z

If you enlarge the image of the Pixiv link in the OP and copy-paste it in tdesktop, it will be sent as this file:

If you open it with a text editor, it contains this:

<html>
<head><title>403 Forbidden</title></head>
<body>
<center><h1>403 Forbidden</h1></center>
<hr><center>nginx</center>
</body>
</html>

It is sent like this:

ilya-fedin · 2021-03-19T14:17:49Z

If you enlarge the image of the Pixiv link in the OP and copy-paste it in tdesktop

Oh, I don't want to create an account :(

arisudesu · 2021-03-19T14:40:55Z

I've recorded what's happening step by step with request logging on local server: https://a.pomf.cat/oldqgq.mp4.

Image is downloaded twice, first time in browser, second time by telegram (?) when pasted.

ilya-fedin · 2021-03-19T14:44:38Z

But tdesktop doesn't have any code for downloading any stuff on pasting. Maybe Qt does this?

reallyuniquename · 2021-03-20T19:47:29Z

That HTTP request comes from Firefox. I assume this has something to do with Firefox (not) caching 80MB image since I can't reproduce this with smaller files. Frankly, I don't know. Good catch though.

Also I do not recommend testing this with Pixiv, they prevent direct image access even for authorized users.

Aokromes · 2021-03-20T19:57:02Z

so, no telegram bug?

reallyuniquename · 2021-03-20T20:10:21Z

Probably not.

But it would be better to investigate this from Telegram side because some other applications manage to paste images from Firefox without this issue.

arisudesu · 2021-03-21T10:51:00Z

That HTTP request comes from Firefox. I assume this has something to do with Firefox (not) caching 80MB image since I can't reproduce this with smaller files. Frankly, I don't know. Good catch though.

It happens with small images too, except that you don't notice the delay.

reallyuniquename · 2021-03-21T12:01:32Z

It happens with small images too

For me it doesn't. Try something small like 256x256px and under 25KB. There is no additional request and no file:// thingy as @RememberTheAir described, i.e. image data is being copied by value and not by reference.

arisudesu · 2021-03-27T13:45:41Z

It happens for me: https://a.pomf.cat/rjiwza.mp4. Github avatar is 11274 bytes long.

I don't clearly understand what is happening between telegram and firefox.

reallyuniquename · 2021-03-27T15:12:36Z

@arisudesu You are right, it does happen with Github avatar.

Could you try serving the same image through local python HTTP server? For me it doesn't log any additional requests. Maybe it's not just about image size. Still, looks like a caching issue on Firefox side?

ilya-fedin · 2021-03-27T17:58:08Z

maybe the file firefox creates in temp directory is not a regular file, but some kind of special file, so that when some app tries to access it, Firefox gets it from internal cache or (depending on cache settings) asks it from the server again? This could be some new Firefox feature and can describe why such an issue appeared only now.

ilya-fedin · 2021-03-27T18:06:12Z

It happens for me: https://a.pomf.cat/rjiwza.mp4.

ah, the file is created after pasting. So it could be that Firefox sets some native handle in clipboard message, so that Windows itself asks Firefox to download file on pasting.

ilya-fedin · 2021-03-27T18:06:55Z

At that point it's worth for you @arisudesu and @reallyuniquename to compare your Firefox versions

arisudesu · 2021-03-27T19:39:35Z

Mine is 87.0, was 86.0 at the moment of opening the issue.

Meanwhile I've debugged Telegram and found what causes the download: it is weird behavior of QMimeData::text() which is used here:

tdesktop/Telegram/SourceFiles/history/history_widget.cpp

Line 364 in a506e9b

return confirmSendingFiles(data, std::nullopt, data->text());

It's Qt downloads file to obtain its file:// uri for text inserted on cancel. I've disabled call to QMimeData::text() here with the code:

return confirmSendingFiles(data, std::nullopt, !data->hasImage() ? data->text() : QString());

But image is still downloaded, so I had to disable one block here:

tdesktop/Telegram/SourceFiles/history/history_widget.cpp

Lines 4470 to 4483 in a506e9b

    
           if (const auto urls = data->urls(); !urls.empty()) { 
        
           	auto list = Storage::PrepareMediaList( 
        
           		urls, 
        
           		st::sendMediaPreviewSize); 
        
           	if (list.error != Ui::PreparedList::Error::NonLocalUrl) { 
        
           		if (list.error == Ui::PreparedList::Error::None 
        
           			|| !hasImage) { 
        
           			const auto emptyTextOnCancel = QString(); 
        
           			list.overrideSendImagesAsPhotos = overrideSendImagesAsPhotos; 
        
           			confirmSendingFiles(std::move(list), emptyTextOnCancel); 
        
           			return true; 
        
           		} 
        
           	} 
        
           }

with check on hasUrls():

if (hasImage && data->hasUrls()) {
    // original code
}

The image isn't downloaded anymore. No file uri is inserted on cancel too, though does it make sense? I don't know.

ilya-fedin · 2021-03-27T19:41:44Z

though does it make sense?

~~it's a bug as well (#8265)~~ UPD: the code looks like it's done on a reason

arisudesu · 2021-03-30T10:47:38Z

Great. Now you can fix both problems in one go.

Although I have already set up a working environment and a fix, it is unlikely I'll be able to make a patch, because Telegram code is huge and I can't be sure if I don't break something else by accident. I leave this to core developers.

stale · 2021-09-26T16:02:21Z

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

aprosvetova · 2021-09-26T16:40:09Z

Unfortunately, the issue is still present on the latest stable version.

stale · 2022-03-27T02:03:56Z

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

arisudesu · 2022-03-27T14:30:47Z

Unfortunately, the issue is still present on the latest stable version.

This bot is kinda useless tbh.

Aokromes · 2022-03-27T14:52:49Z

no it's not, it helps us to close already fixed non-closed issues.

ilya-fedin · 2022-03-27T18:27:35Z

Yeah, stale bot is really useful. People open a lot of issues everyday and stalebot helps rotate them closing issues no one interested in. People like create duplicates and there's no manpower to check all the issues, the time when auto-closer bot was broken and there were no stalebot yet shown that issues reach 1000 numbers very quickly without rotation. An imperfect solution for imperfect world.

github-actions · 2022-09-24T02:15:21Z

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

seiya-git · 2022-09-24T11:42:37Z

Unfortunately, the issue is still present on the latest stable version.

ilya-fedin · 2022-09-24T13:46:55Z

This issue is now a part of #25126

seiya-git · 2023-02-12T15:29:40Z

Unfortunately, the issue is still present on the latest stable version.

ilya-fedin · 2023-02-12T15:34:23Z

No one helped with reporting it to Qt sadly and it seems it has too little priority for @john-preston to look at it

john-preston · 2023-03-06T07:14:44Z

Ok, it looks like I fixed this. We'll check in the next version.

stale bot added the stale label Sep 26, 2021

stale bot removed the stale label Sep 26, 2021

stale bot added the stale label Mar 27, 2022

stale bot removed the stale label Mar 27, 2022

github-actions bot added the stale label Sep 24, 2022

ilya-fedin mentioned this issue Sep 24, 2022

Issues needing community help on reports to third-party projects #25126

Open

github-actions bot removed the stale label Sep 25, 2022

Aokromes added the 3rd party issue label Feb 12, 2023

Aokromes added the waiting for answer label Mar 6, 2023

john-preston closed this as completed in ff4af1b Mar 8, 2023

github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy-pasting from Firefox downloads image again #10564

Copy-pasting from Firefox downloads image again #10564

arisudesu commented Mar 18, 2021 •

edited

Loading

ilya-fedin commented Mar 19, 2021

arisudesu commented Mar 19, 2021 •

edited

Loading

RememberTheAir commented Mar 19, 2021 •

edited

Loading

ilya-fedin commented Mar 19, 2021

RememberTheAir commented Mar 19, 2021 •

edited

Loading

ilya-fedin commented Mar 19, 2021

arisudesu commented Mar 19, 2021 •

edited

Loading

ilya-fedin commented Mar 19, 2021 •

edited

Loading

reallyuniquename commented Mar 20, 2021

Aokromes commented Mar 20, 2021

reallyuniquename commented Mar 20, 2021 •

edited

Loading

arisudesu commented Mar 21, 2021

reallyuniquename commented Mar 21, 2021

arisudesu commented Mar 27, 2021

reallyuniquename commented Mar 27, 2021

ilya-fedin commented Mar 27, 2021 •

edited

Loading

ilya-fedin commented Mar 27, 2021

ilya-fedin commented Mar 27, 2021

arisudesu commented Mar 27, 2021

ilya-fedin commented Mar 27, 2021 •

edited

Loading

arisudesu commented Mar 30, 2021

stale bot commented Sep 26, 2021

aprosvetova commented Sep 26, 2021

stale bot commented Mar 27, 2022

arisudesu commented Mar 27, 2022

Aokromes commented Mar 27, 2022

ilya-fedin commented Mar 27, 2022 •

edited

Loading

github-actions bot commented Sep 24, 2022

seiya-git commented Sep 24, 2022

ilya-fedin commented Sep 24, 2022

seiya-git commented Feb 12, 2023

ilya-fedin commented Feb 12, 2023

john-preston commented Mar 6, 2023

Copy-pasting from Firefox downloads image again #10564

Copy-pasting from Firefox downloads image again #10564

Comments

arisudesu commented Mar 18, 2021 • edited Loading

Steps to reproduce (example 1)

Steps to reproduce (example 2)

Expected behaviour

Actual behaviour

Configuration

ilya-fedin commented Mar 19, 2021

arisudesu commented Mar 19, 2021 • edited Loading

RememberTheAir commented Mar 19, 2021 • edited Loading

ilya-fedin commented Mar 19, 2021

RememberTheAir commented Mar 19, 2021 • edited Loading

ilya-fedin commented Mar 19, 2021

arisudesu commented Mar 19, 2021 • edited Loading

ilya-fedin commented Mar 19, 2021 • edited Loading

reallyuniquename commented Mar 20, 2021

Aokromes commented Mar 20, 2021

reallyuniquename commented Mar 20, 2021 • edited Loading

arisudesu commented Mar 21, 2021

reallyuniquename commented Mar 21, 2021

arisudesu commented Mar 27, 2021

reallyuniquename commented Mar 27, 2021

ilya-fedin commented Mar 27, 2021 • edited Loading

ilya-fedin commented Mar 27, 2021

ilya-fedin commented Mar 27, 2021

arisudesu commented Mar 27, 2021

ilya-fedin commented Mar 27, 2021 • edited Loading

arisudesu commented Mar 30, 2021

stale bot commented Sep 26, 2021

aprosvetova commented Sep 26, 2021

stale bot commented Mar 27, 2022

arisudesu commented Mar 27, 2022

Aokromes commented Mar 27, 2022

ilya-fedin commented Mar 27, 2022 • edited Loading

github-actions bot commented Sep 24, 2022

seiya-git commented Sep 24, 2022

ilya-fedin commented Sep 24, 2022

seiya-git commented Feb 12, 2023

ilya-fedin commented Feb 12, 2023

john-preston commented Mar 6, 2023

arisudesu commented Mar 18, 2021 •

edited

Loading

arisudesu commented Mar 19, 2021 •

edited

Loading

RememberTheAir commented Mar 19, 2021 •

edited

Loading

RememberTheAir commented Mar 19, 2021 •

edited

Loading

arisudesu commented Mar 19, 2021 •

edited

Loading

ilya-fedin commented Mar 19, 2021 •

edited

Loading

reallyuniquename commented Mar 20, 2021 •

edited

Loading

ilya-fedin commented Mar 27, 2021 •

edited

Loading

ilya-fedin commented Mar 27, 2021 •

edited

Loading

ilya-fedin commented Mar 27, 2022 •

edited

Loading