Remove dependency on deprecated domain module #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed wrong variable restored default values remove obsolete library Added missing curl needed in health checks Updated curl doc
fgalan
reviewed
Nov 20, 2023
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #498
domainmodule is deprecated since node 10 (https://nodejs.org/docs/latest-v10.x/api/domain.html). It is used to improve logging, by storing information related to the request in a per-request domain. The callback provided to functiongetContextof logops package queries that domain to retrieve request information.This PR replaces the global logger with a per-request instance, stored in
req.logger. This instance is created by a middleware that runs early in the chain, and populates the per-request logger instance with the same information that used to be in the context.All the middleware and handlers are also refactored to use the per-request logger instead of the global one, so this PR can dispose of the
logger.getContextcallback and thedomaindependency.