Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not to specify TriggerTemplate as resource type? #1726

Closed
dancer1325 opened this issue Feb 23, 2024 · 4 comments · Fixed by #1727
Closed

Why not to specify TriggerTemplate as resource type? #1726

dancer1325 opened this issue Feb 23, 2024 · 4 comments · Fixed by #1727
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@dancer1325
Copy link

Expected Behavior

Specify clearly that 'TriggerTemplate' is a resource under the package 'triggers.tekton.dev/v1beta1', since it's a standalone CR

Resource Types:
ClusterTriggerBinding
EventListener
Trigger
TriggerBinding
TriggerTemplate

Actual Behavior

'TriggerTemplate' is NOT specified clearly as a CR

Resource Types:
ClusterTriggerBinding
EventListener
Trigger
TriggerBinding

Steps to Reproduce the Problem

  1. Navigate to https://tekton.dev/docs/triggers/triggers-api/#triggers.tekton.dev/v1beta1

Additional Info

@dancer1325 dancer1325 added the kind/bug Categorizes issue or PR as related to a bug. label Feb 23, 2024
@AlanGreene
Copy link
Member

Thanks for reporting this @dancer1325

tektoncd/triggers would be the right place for this, @dibyom can you transfer the issue please?

@dibyom dibyom transferred this issue from tektoncd/website May 2, 2024
@dibyom
Copy link
Member

dibyom commented May 2, 2024

cc @khrm @savitaashture - this looks like a missing tag somewhere?

@khrm
Copy link
Contributor

khrm commented May 3, 2024

The Tag was there. Not sure why it requires a new line before it.
https://github.com/tektoncd/triggers/pull/1727/files#diff-b298db60f09e46c7935921f4e629ae4066da95202fccdfb1fd42b11b4ede776f

@khrm
Copy link
Contributor

khrm commented May 3, 2024

/assign @khrm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants