Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggers do not include TriggerTemplate labels when creating resources #1689

Closed
ggallen opened this issue Feb 6, 2024 · 2 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ggallen
Copy link

ggallen commented Feb 6, 2024

Expected Behavior

When a TriggerTemplate resource template contains labels, those labels should be included in the created resource.

Actual Behavior

The labels are not included in the created resource.

Steps to Reproduce the Problem

  1. Create a TriggerTemplate with a resourceTemplate that contains labels in the metadata.
  2. Create a Trigger that uses the defined TriggerTemplate.
  3. Cause the trigger to fire and create the resource.

Additional Info

  • Kubernetes version:

    Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.10", GitCommit:"0fa26aea1d5c21516b0d96fea95a77d8d429912e", GitTreeState:"clean", BuildDate:"2024-01-17T13:46:28Z", GoVersion:"go1.20.13", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.10", GitCommit:"0fa26aea1d5c21516b0d96fea95a77d8d429912e", GitTreeState:"clean", BuildDate:"2024-01-17T13:38:41Z", GoVersion:"go1.20.13", Compiler:"gc", Platform:"linux/amd64"}
  • Tekton Pipeline version:

    v0.53.3

  • Tekton Triggers version:

    v0.25.3

@ggallen ggallen added the kind/bug Categorizes issue or PR as related to a bug. label Feb 6, 2024
@savitaashture
Copy link
Contributor

Hi @ggallen 👋

I see its an issue with Pipeline
I mean even if you try directly customRun without using Triggers you face the same issue

So can you create an issue in Pipeline?

@ggallen
Copy link
Author

ggallen commented Feb 6, 2024

Superseded by tektoncd/pipeline#7639.

@ggallen ggallen closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants