Skip to content

chore: use official artifacthub stepactions for git-clone#2767

Open
theakshaypant wants to merge 2 commits into
mainfrom
test-pr-2758-chmouel
Open

chore: use official artifacthub stepactions for git-clone#2767
theakshaypant wants to merge 2 commits into
mainfrom
test-pr-2758-chmouel

Conversation

@theakshaypant

Copy link
Copy Markdown
Member

📝 Description of the Change

Replace the vendored git-clone StepAction (.tekton/stepactions/git-clone.yaml) with a reference to the upstream tektoncd catalog via the hub resolver. The local copy was a verbatim duplicate of catalog version 0.2 — no reason to carry it.

Also fixes error wrapping in DetectPacInstallation (%s + .Error()%w) to preserve the error chain for errors.Is/errors.As.

Clone of #2758 with the changes requested in #2758 (review)

🔗 Linked GitHub Issue

Fixes #

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any issues. For an efficient workflow, I have considered installing pre-commit and running pre-commit install to automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.

Preserves the error chain for errors.Is/errors.As callers.

Co-Authored-By: Claude <noreply@anthropic.com>
@theakshaypant theakshaypant requested a review from vdemeester June 9, 2026 03:45

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Tekton pipeline configurations to use the Hub resolver for the git-clone stepaction (version 1.7.0) instead of the HTTP resolver, and removes the local stepaction definition. Additionally, it improves error handling in bootstrap.go by wrapping the error with %w. Feedback was provided regarding a version mismatch in the test data, which still references version 1.6.0 of the stepaction instead of 1.7.0.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread test/testdata/pipelinerun-stepactions.yaml Outdated
Replaced the local HTTP-based git-clone stepaction with the official
Tekton Hub resolver across Tekton workflows. Removed the redundant
local stepaction definition file to keep configuration centralized.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@theakshaypant theakshaypant force-pushed the test-pr-2758-chmouel branch from a9a1bdd to b54f7be Compare June 9, 2026 04:00
@theakshaypant

Copy link
Copy Markdown
Member Author

/test

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.73%. Comparing base (402d5c7) to head (b54f7be).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2767   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files         210      210           
  Lines       21112    21112           
=======================================
  Hits        12611    12611           
  Misses       7706     7706           
  Partials      795      795           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants