fix(github): use provided target ref in GetFileInsideRepo#2696
Merged
zakisk merged 1 commit intoApr 27, 2026
Merged
Conversation
zakisk
approved these changes
Apr 21, 2026
654ef3b to
0036cd9
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2696 +/- ##
==========================================
+ Coverage 59.01% 59.02% +0.01%
==========================================
Files 208 208
Lines 20452 20452
==========================================
+ Hits 12069 12072 +3
+ Misses 7609 7607 -2
+ Partials 774 773 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Should be cherry-picked to |
Member
why? is it asked by anyone? |
Member
|
also can you please add unit tests? |
0036cd9 to
20a9738
Compare
Member
Author
Added unit tests for the changes in 20a9738
We can discuss this offline. |
GetFileInsideRepo ignored the caller-supplied target ref and substituted runevent.BaseBranch. This caused OWNERS ACL checks to read from the wrong branch when a PR targets a non-default branch, and remote task fetches to resolve against the PR base instead of the specified ref. Signed-off-by: Akshay Pant <akpant@redhat.com>
05d10ae to
fcb2f52
Compare
zakisk
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description of the Change
GetFileInsideRepo ignored the caller-supplied target ref and substituted runevent.BaseBranch. This caused OWNERS ACL checks to read from the wrong branch when a PR targets a non-default branch, and remote task fetches to resolve against the PR base instead of the specified ref.
🔗 Linked GitHub Issue
N/A
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.