-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote onerror
Tasks to beta
#8090
Promote onerror
Tasks to beta
#8090
Conversation
b937f89
to
dd11b43
Compare
This PR promotes the feature ignore Task Errors to beta. It was originally released in v0.55.
dd11b43
to
b1a5bec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Thanks a bunch @chitrangpatel for this promotion. We are planning to utilize this feature in our deployment. While we are experimenting with this feature, we ran into the following limitation.
But in a finally task, how to distinguish between a failed task and a task with failure ignored. At the time of designing |
@pritidesai we probably want to create a follow-up issue for this 👼🏼 |
Would this require a TEP? 😸 |
I don't think a TEP will be required here since it's not adding new fields. It's providing access to existing fields via substitutions so I think we can probably justify it over an issue and implement it. |
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind feature