Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote onerror Tasks to beta #8090

Merged

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Jul 3, 2024

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Promote Ignore Task Failure to Beta

/kind feature

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
This PR promotes the feature ignore Task Errors to beta.
It was originally released in v0.55.
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@JeromeJu
Copy link
Member

JeromeJu commented Jul 4, 2024

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@tekton-robot tekton-robot merged commit fbef03d into tektoncd:main Jul 4, 2024
14 checks passed
@chitrangpatel chitrangpatel added this to the Pipeline v0.62 milestone Jul 4, 2024
@pritidesai
Copy link
Member

Thanks a bunch @chitrangpatel for this promotion. We are planning to utilize this feature in our deployment. While we are experimenting with this feature, we ran into the following limitation.

  • Not able to access task's status (specifically reason) in finally tasks

tkn describes the list of taskRuns as expected:

🗂  Taskruns

 NAME                                                  TASK NAME       STARTED         DURATION   STATUS
 ∙ pipelinerun-with-failing-task-8lz7x-finish          finish          4 minutes ago   4s         Succeeded
 ∙ pipelinerun-with-failing-task-8lz7x-echo-fail       echo-fail       4 minutes ago   4s         Failed
 ∙ pipelinerun-with-failing-task-8lz7x-echo-continue   echo-continue   4 minutes ago   4s         Failed(FailureIgnored)

But in a finally task, how to distinguish between a failed task and a task with failure ignored.

At the time of designing onError feature at the step level, the step exit code is made available to subsequent steps. Similarly, we are looking for a way to classify a task which failed but with FailureIgnored.

@vdemeester
Copy link
Member

@pritidesai we probably want to create a follow-up issue for this 👼🏼

@pritidesai
Copy link
Member

@pritidesai we probably want to create a follow-up issue for this 👼🏼

#8110

Would this require a TEP? 😸

@chitrangpatel
Copy link
Contributor Author

@pritidesai we probably want to create a follow-up issue for this 👼🏼

#8110

Would this require a TEP? 😸

I don't think a TEP will be required here since it's not adding new fields. It's providing access to existing fields via substitutions so I think we can probably justify it over an issue and implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants