Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a doc for upgrading Hub v1.6.0 to v1.7.0 #389

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

pratap0007
Copy link
Contributor

  • This doc defines the steps for upgrading Hub v1.6.0 to
    v1.7.0 as metadata name and labels are changed for db,
    api and ui configs.
  • Updates deployment and development docs.

Signed-off-by: Shiv Verma shverma@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 3, 2022
@pratap0007 pratap0007 force-pushed the hub-upgrade-doc branch 2 times, most recently from b29cc1d to 8078263 Compare March 4, 2022 06:09
@@ -0,0 +1,274 @@
# Upgared Hub v1.6.0 to v1.7.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Upgrade

@@ -0,0 +1,274 @@
# Upgared Hub v1.6.0 to v1.7.0

This doc defines the steps to follow for upgrading the Hub v1.6.0 to Hub v1.7.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This doc defines the steps to follow for upgrading the Hub v1.6.0 to Hub v1.7.0.
This doc defines the steps to follow for upgrading from Hub v1.6.0 to Hub v1.7.0.


This doc defines the steps to follow for upgrading the Hub v1.6.0 to Hub v1.7.0.

Navigate to `config` directoy in the root of the project and considering the `tekton-hub` namsespace.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to consider the namespace here


Navigate to `config` directoy in the root of the project and considering the `tekton-hub` namsespace.

## Database Deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Database Deploy
## Deploy Database

Execute the below command

```
kubectl apply -f 00-init/ -n tekton-hub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also we don't need to consider the namespace

Create a file within the pod and dump the Hub v1.6.0 db by running following following commands

```
touch /tmp/db.dump
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to create the file, running the pg_dump command will create one for it

Exit from the pod and copy the Hub v1.6.0 dump db file from the db pod to your system

```
touch backup_db.dump
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also same we don't need to create a file


Navigate to `config` directoy in the root of the project and considering the `tekton-hub` namsespace.

## Database Deploy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get the backup of database first and then create a new deployment of db


kubectl exec -it <hub_v1.7.0_db_pod_name> /bin/bash

touch /tmp/backup_db.dump
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Comment on lines 60 to 64
kubectl get pods -l app=tekton-hub-db -n tekton-hub

kubectl exec -it <hub_v1.7.0_db_pod_name> /bin/bash

touch /tmp/backup_db.dump
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can omit this steps


Edit the `02-api/22-api-deployment.yaml` and replace the image with Hub v1.7.0 API image

### apply API configs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### apply API configs
### Apply API configs

Copy link
Member

@PuneetPunamiya PuneetPunamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the patch looks good, could you please address the minor comments

This doc defines the steps for upgrading Hub v1.6.0 to
v1.7.0 as metadata name and labels are changed for db,
api and ui configs.
Updates deployment and development docs.

Signed-off-by: Shiv Verma <shverma@redhat.com>
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 4, 2022
@PuneetPunamiya
Copy link
Member

/approve
/meow

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022
@piyush-garg
Copy link
Contributor

Do we need any change in any script ?

@pratap0007
Copy link
Contributor Author

Do we need any change in any script ?

I think there are no changes required cc: @sm43 @PuneetPunamiya

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022
@tekton-robot tekton-robot merged commit 69363e4 into tektoncd:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants