-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a doc for upgrading Hub v1.6.0 to v1.7.0 #389
Conversation
b29cc1d
to
8078263
Compare
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
@@ -0,0 +1,274 @@ | |||
# Upgared Hub v1.6.0 to v1.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Upgrade
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
@@ -0,0 +1,274 @@ | |||
# Upgared Hub v1.6.0 to v1.7.0 | |||
|
|||
This doc defines the steps to follow for upgrading the Hub v1.6.0 to Hub v1.7.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc defines the steps to follow for upgrading the Hub v1.6.0 to Hub v1.7.0. | |
This doc defines the steps to follow for upgrading from Hub v1.6.0 to Hub v1.7.0. |
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
|
||
This doc defines the steps to follow for upgrading the Hub v1.6.0 to Hub v1.7.0. | ||
|
||
Navigate to `config` directoy in the root of the project and considering the `tekton-hub` namsespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to consider the namespace here
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
|
||
Navigate to `config` directoy in the root of the project and considering the `tekton-hub` namsespace. | ||
|
||
## Database Deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Database Deploy | |
## Deploy Database |
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
Execute the below command | ||
|
||
``` | ||
kubectl apply -f 00-init/ -n tekton-hub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here also we don't need to consider the namespace
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
Create a file within the pod and dump the Hub v1.6.0 db by running following following commands | ||
|
||
``` | ||
touch /tmp/db.dump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to create the file, running the pg_dump command will create one for it
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
Exit from the pod and copy the Hub v1.6.0 dump db file from the db pod to your system | ||
|
||
``` | ||
touch backup_db.dump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here also same we don't need to create a file
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
|
||
Navigate to `config` directoy in the root of the project and considering the `tekton-hub` namsespace. | ||
|
||
## Database Deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to get the backup of database first and then create a new deployment of db
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
|
||
kubectl exec -it <hub_v1.7.0_db_pod_name> /bin/bash | ||
|
||
touch /tmp/backup_db.dump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
kubectl get pods -l app=tekton-hub-db -n tekton-hub | ||
|
||
kubectl exec -it <hub_v1.7.0_db_pod_name> /bin/bash | ||
|
||
touch /tmp/backup_db.dump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can omit this steps
docs/UPGRADE_V1.6.0_TO_V1.7.0.md
Outdated
|
||
Edit the `02-api/22-api-deployment.yaml` and replace the image with Hub v1.7.0 API image | ||
|
||
### apply API configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### apply API configs | |
### Apply API configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the patch looks good, could you please address the minor comments
8078263
to
6a28df8
Compare
This doc defines the steps for upgrading Hub v1.6.0 to v1.7.0 as metadata name and labels are changed for db, api and ui configs. Updates deployment and development docs. Signed-off-by: Shiv Verma <shverma@redhat.com>
6a28df8
to
b904b8d
Compare
/approve |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do we need any change in any script ? |
I think there are no changes required cc: @sm43 @PuneetPunamiya |
/lgtm |
v1.7.0 as metadata name and labels are changed for db,
api and ui configs.
Signed-off-by: Shiv Verma shverma@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-check
make ui-check
See the contribution guide for more details.