Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIP] Pipelines In Pipelines #705

Merged
merged 1 commit into from
Feb 26, 2021
Merged

[PIP] Pipelines In Pipelines #705

merged 1 commit into from
Feb 26, 2021

Conversation

jerop
Copy link
Member

@jerop jerop commented Feb 22, 2021

Changes

This is an experimental project to provide support for Pipelines in
Pipelines to improve the composability and reusability of Tekton Pipelines.
The functionality is provided by a controller that implements the
Custom Task interface.

Its use cases include enabling defining and executing a set of Tasks
as a complete unit of execution and decoupling Pipeline branches
failures such that a Task failure in one branch does not stop
execution of unrelated Pipeline branches.

Pipelines in Pipelines is proposed in tektoncd/community#330
Issue is further described in tektoncd/pipeline#2134

Future work includes enabling passing in inputs through Parameters,
producing outputs through Results, propagating timeouts, among others.

/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Commit messages includes a project tag in the subject - e.g. [OCI], [hub], [results], [task-loops]

See the contribution guide for more details.

/cc @afrittoli @bobcatfish @imjasonh

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 22, 2021
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 🎉 🙏
It looks great, I added a couple of NITs / questions / comments, but nothing that cannot be addressed in a different patch.
/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@afrittoli
Copy link
Member

Perhaps we could merge #706 first so we could see the tests running?

@jerop jerop changed the title [PIP] Pipelines In Pipelines Custom Tasks [PIP] Pipelines In Pipelines Feb 25, 2021
@afrittoli
Copy link
Member

Thanks for all the updates @jerop .
I don't see the changes from #706 in here?
Thank you 🙏

@jerop
Copy link
Member Author

jerop commented Feb 26, 2021

Thanks for all the updates @jerop .
I don't see the changes from #706 in here?
Thank you 🙏

just pushed it, thanks :)

@afrittoli
Copy link
Member

Thanks for all the updates @jerop .
I don't see the changes from #706 in here?
Thank you 🙏

just pushed it, thanks :)

Thank you!
Unit tests are running for PIP now, it looks like there is a failure.

This is an experimental project to provide support for `Pipelines` in
`Pipelines` to improve the composability and reusability of
[Tekton Pipelines](https://github.com/tektoncd/pipeline).

The functionality is provided by a controller
that implements the `Custom Task` interface.

Its use cases include enabling defining and executing a set of `Tasks`
as a complete unit of execution and decoupling `Pipeline` branches
failures such that a `Task` failure in one branch does not stop
execution of unrelated `Pipeline` branches.

Experimental project is proposed in tektoncd/community#330
Issue is further described in tektoncd/pipeline#2134
@jerop
Copy link
Member Author

jerop commented Feb 26, 2021

Unit tests are running for PIP now, it looks like there is a failure.

yes, needed to add the event from the permanent error I added, fixed now

thanks for the reviews @afrittoli!

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2021
@tekton-robot tekton-robot merged commit e5f5078 into tektoncd:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants