-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIP] Pipelines In Pipelines #705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 🎉 🙏
It looks great, I added a couple of NITs / questions / comments, but nothing that cannot be addressed in a different patch.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Perhaps we could merge #706 first so we could see the tests running? |
This is an experimental project to provide support for `Pipelines` in `Pipelines` to improve the composability and reusability of [Tekton Pipelines](https://github.com/tektoncd/pipeline). The functionality is provided by a controller that implements the `Custom Task` interface. Its use cases include enabling defining and executing a set of `Tasks` as a complete unit of execution and decoupling `Pipeline` branches failures such that a `Task` failure in one branch does not stop execution of unrelated `Pipeline` branches. Experimental project is proposed in tektoncd/community#330 Issue is further described in tektoncd/pipeline#2134
yes, needed to add the event from the permanent error I added, fixed now thanks for the reviews @afrittoli! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
This is an experimental project to provide support for
Pipelines
inPipelines
to improve the composability and reusability of Tekton Pipelines.The functionality is provided by a controller that implements the
Custom Task
interface.Its use cases include enabling defining and executing a set of
Tasks
as a complete unit of execution and decoupling
Pipeline
branchesfailures such that a
Task
failure in one branch does not stopexecution of unrelated
Pipeline
branches.Pipelines in Pipelines is proposed in tektoncd/community#330
Issue is further described in tektoncd/pipeline#2134
Future work includes enabling passing in inputs through
Parameters
,producing outputs through
Results
, propagating timeouts, among others./kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
/cc @afrittoli @bobcatfish @imjasonh