Skip to content

Commit 25350fc

Browse files
committed
Final fixes for new release 0.3.2
1 parent b949bc6 commit 25350fc

File tree

9 files changed

+19
-11
lines changed

9 files changed

+19
-11
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
![Version](https://img.shields.io/badge/Godot-v4.0%20RC%205-informational) ![License](https://img.shields.io/github/license/tefusion/godot-subdiv)
1+
![Version](https://img.shields.io/badge/Godot-v4.0.2-informational) ![License](https://img.shields.io/github/license/tefusion/godot-subdiv)
22
# Godot Subdiv
33

44
| ![UV Subdivision](UVSubdivision.gif) | ![Skinning subdivision](SkinningSubdivision.gif) |

project/addons/godot_subdiv/plugin.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
name="Godot Subdiv"
44
description="Fast subdivision in Godot with opensubdiv."
55
author="tefusion"
6-
version="0.3.1"
6+
version="0.3.2"
77
script="godot_subdiv.gd"

src/import/topology_data_importer.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,8 @@ void TopologyDataImporter::convert_importer_meshinstance_to_subdiv(Object *impor
148148
Ref<ImporterMesh> subdiv_importer_mesh;
149149
subdiv_importer_mesh.instantiate();
150150

151-
Ref<SubdivisionBaker> baker = memnew(SubdivisionBaker);
151+
Ref<SubdivisionBaker> baker;
152+
baker.instantiate();
152153
subdiv_importer_mesh = baker->get_importer_mesh(subdiv_importer_mesh, topology_data_mesh, subdiv_level, true);
153154
importer_mesh_instance->set_mesh(subdiv_importer_mesh);
154155
if (import_mode == ImportMode::ARRAY_MESH) {

src/resources/baked_subdiv_mesh.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ int BakedSubdivMesh::get_subdiv_level() const {
2525

2626
void BakedSubdivMesh::_update_subdiv() {
2727
if (data_mesh.is_valid()) {
28-
Ref<SubdivisionBaker> baker = memnew(SubdivisionBaker);
28+
Ref<SubdivisionBaker> baker;
29+
baker.instantiate();
2930
_clear();
3031

3132
//add blendshapes

src/subdivision/quad_subdivider.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ OpenSubdiv::Sdc::SchemeType QuadSubdivider::_get_refiner_type() const {
99
}
1010

1111
Array QuadSubdivider::_get_triangle_arrays() const {
12-
Ref<SurfaceTool> st = memnew(SurfaceTool);
12+
Ref<SurfaceTool> st;
13+
st.instantiate();
1314

1415
bool use_uv = topology_data.uv_array.size();
1516
bool use_bones = topology_data.bones_array.size();

src/subdivision/subdivision_baker.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@
66
Array SubdivisionBaker::get_baked_arrays(const Array &topology_arrays, int p_level, int64_t p_format, TopologyDataMesh::TopologyType topology_type) {
77
switch (topology_type) {
88
case TopologyDataMesh::QUAD: {
9-
Ref<QuadSubdivider> subdivider = memnew(QuadSubdivider);
9+
Ref<QuadSubdivider> subdivider;
10+
subdivider.instantiate();
1011
return subdivider->get_subdivided_arrays(topology_arrays, p_level, p_format, true);
1112
}
1213

1314
case TopologyDataMesh::TRIANGLE: {
14-
Ref<TriangleSubdivider> subdivider = memnew(TriangleSubdivider);
15+
Ref<TriangleSubdivider> subdivider;
16+
subdivider.instantiate();
1517
return subdivider->get_subdivided_arrays(topology_arrays, p_level, p_format, true);
1618
}
1719

src/subdivision/subdivision_mesh.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,14 @@
1818
Array SubdivisionMesh::_get_subdivided_arrays(const Array &p_arrays, int p_level, int32_t p_format, bool calculate_normals, TopologyDataMesh::TopologyType topology_type) {
1919
switch (topology_type) {
2020
case TopologyDataMesh::QUAD: {
21-
Ref<QuadSubdivider> subdivider = memnew(QuadSubdivider);
21+
Ref<QuadSubdivider> subdivider;
22+
subdivider.instantiate();
2223
return subdivider->get_subdivided_arrays(p_arrays, p_level, p_format, calculate_normals);
2324
}
2425

2526
case TopologyDataMesh::TRIANGLE: {
26-
Ref<TriangleSubdivider> subdivider = memnew(TriangleSubdivider);
27+
Ref<TriangleSubdivider> subdivider;
28+
subdivider.instantiate();
2729
return subdivider->get_subdivided_arrays(p_arrays, p_level, p_format, calculate_normals);
2830
}
2931

src/subdivision/triangle_subdivider.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ OpenSubdiv::Sdc::SchemeType TriangleSubdivider::_get_refiner_type() const {
99
}
1010

1111
Array TriangleSubdivider::_get_triangle_arrays() const {
12-
Ref<SurfaceTool> st = memnew(SurfaceTool);
12+
Ref<SurfaceTool> st;
13+
st.instantiate();
1314

1415
bool use_uv = topology_data.uv_array.size();
1516
bool use_bones = topology_data.weights_array.size();

0 commit comments

Comments
 (0)