move root clazz lookup to a separate method #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-b
force-pushed
the
xsdata-root-clazz
branch
2 times, most recently
from
a663972 to
66a576b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 115 115
Lines 9276 9279 +3
Branches 1417 1417
=========================================
+ Hits 9276 9279 +3 ☔ View full report in Codecov by Sentry. |
…tend it by subclassing
leo-b
force-pushed
the
xsdata-root-clazz
branch
from
66a576b to
7dad91b
Compare
tefra
reviewed
Nov 9, 2024
| """ | ||
| Obtain the root clazz, maybe from the provided clazz. | ||
|
|
||
| :param clazz: Root class type, if it's missing look for any |
|
tefra
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #767, I need some kind of dynamic hook to determine the class of the root element.
My PR #766 got rejected, my next approach is to simply move the root clazz lookup code to a separate method in order to be able to extend it by subclassing.