You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently with version 1.34, the test still passes when the dmesg after check fails.
I think the desired outcome is for the test to fail when dmesg after fails.
And if dmesg before fails the test should end in warning at least, but not pass.
@sbertramrh, could you please have a look at #3239 and verify that the proposed implementation would cover your use case well? Thanks.
I found it hard to understand, but I think this part of the discussion is what is relevant?
if interpret == ResultInterpret.XFAIL:
if self.result == ResultOutcome.PASS and checks_failed:
self.result = ResultOutcome.FAIL
If so then yes.
Also as mentioned in this ticket entry if the before test portion is the only part that fails for the check, the test should be self.result = ResultOutcome.WARN.
I will mention on the other ticket as well thanks.
Currently with version 1.34, the test still passes when the dmesg after check fails.
I think the desired outcome is for the test to fail when dmesg after fails.
And if dmesg before fails the test should end in warning at least, but not pass.
e.g.
The text was updated successfully, but these errors were encountered: