Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement nested fmf structures #82

Open
sopos opened this issue Oct 1, 2020 · 5 comments
Open

implement nested fmf structures #82

sopos opened this issue Oct 1, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@sopos
Copy link

sopos commented Oct 1, 2020

Image a node where I define a reference to another git repo where the branch continues.
I can image a reserved attribute

fmf_subtree:
  url: https://github.com/...
  reference: master

such repo would be pulled and the tree would be simply extended by this part.

It is still questionable how the inheritance should behave at such points where a new fmf tree begins. This might be controlled by another attribute of fmf_subtree, e.g. boolean inheritance.

fmf_subtree:
  url: https://github.com/...
  reference: master
  inheritance: true
@psss psss added the enhancement New feature or request label Oct 1, 2020
@sopos
Copy link
Author

sopos commented Oct 5, 2020

one more possible extension would be usage of path attribute which would allow one to use just a sub-tree of the target repo which could be another form of filtering or selecting just a subset of the metadata (e.g. include plans only, or tests only if organized separately).

fmf_subtree:
  url: https://github.com/RedHat-SP-Security/tests
  reference: master
  inheritance: true
  path: /usbguard

@sopos
Copy link
Author

sopos commented Oct 6, 2020

I think I have another use case:
as a tester of component A I want to include on test of component B to my scope.
Typically I would like to add a selinux-policy tests to be executed as part of my component testing or vice versa, my test might help with selinux-policy testing.
There might be better way, though.

@jscotka
Copy link
Collaborator

jscotka commented Jan 5, 2021

this PR #54 probably also implements what you want.
It is little bit tricky, that I needs to download remote git separately, but in fact, it works well and also allows referencing nodes inside remote tree.

Another solution what your need is clone git repo separately to subdir (of use git submodule inside your preferred path inside) and just remove .fmf dir inside this cloned dir and it will create exactly what you want. (trouble could be with semantics e.g. using relative path pargument for test execution)

@psss
Copy link
Collaborator

psss commented Jan 19, 2021

Hm, I guess #99 is a duplicate of this, right?

@sopos
Copy link
Author

sopos commented Jan 19, 2021

Yep, looks like the idea is basically the same. The difference might be the granularity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants